Skip to content

Commit ed9718f

Browse files
masneybgregkh
authored andcommitted
rtc: ds1307: fix incorrect maximum clock rate handling
[ Upstream commit cf6eb54 ] When ds3231_clk_sqw_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: 6c6ff14 ("rtc: ds1307: add clock provider support for DS3231") Signed-off-by: Brian Masney <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 1ced449 commit ed9718f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/rtc/rtc-ds1307.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1466,7 +1466,7 @@ static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rate,
14661466
return ds3231_clk_sqw_rates[i];
14671467
}
14681468

1469-
return 0;
1469+
return ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1];
14701470
}
14711471

14721472
static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate,

0 commit comments

Comments
 (0)