Skip to content

Commit 397e55c

Browse files
authored
Merge pull request #634 from prachimulay17/docs/fix-doctype
DOC: Fix Typos in README.md and ONBOARDING.md
2 parents 0de2a2d + 277622d commit 397e55c

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

ONBOARDING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Onboarding Guide
22

3-
Client side set up is straight forward and standard, i.e clone the repo [Resonte Client Side Repo](https://github.com/AOSSIE-Org/Resonate), do `flutter pub get` in the root of the project etc so this guide would focus on the backend env set up.
3+
Client-side set-up is straightforward and standard, i.e., clone the repo [Resonate Client Side Repo](https://github.com/AOSSIE-Org/Resonate), do `flutter pub get` in the root of the project, etc. This guide would focus on the backend env setup.
44

5-
Please strictly stick to the guide do not go off installing stuff on your own
5+
Please strictly stick to the guide; do not go off installing stuff on your own.
66

77
> #### **Setting up Firebase for FCM**
8-
> To ensure that new contributors do not have to setup firebase projects, all Firebase functionality (Only used for Notifications via FCM) has been disabled in the application. To enable this functionality (if you want to test notifications), setup a project on firebase, configure Resonate to use your project using this [guide](https://firebase.google.com/docs/flutter/setup) and uncomment the Firebase and FCM specific code in the files: ```main.dart , auth_state_controller.dart, and upcomming_rooms_controller.dart ``` Also, in the [Resonate Backend Repo](https://github.com/AOSSIE-Org/Resonate-Backend), uncomment the FCM and Firebase code in the `Upcoming Rooms Time Checker Function` and add your google-services.json in the folder for that function before setting up the localhost backend.
8+
> To ensure that new contributors do not have to setup firebase projects, all Firebase functionality (Only used for Notifications via FCM) has been disabled in the application. To enable this functionality (if you want to test notifications), set up a project on firebase, configure Resonate to use your project using this [guide](https://firebase.google.com/docs/flutter/setup) and uncomment the Firebase and FCM-specific code in the files: ```main.dart, auth_state_controller.dart, and upcomming_rooms_controller.dart``` Also, in the [Resonate Backend Repo](https://github.com/AOSSIE-Org/Resonate-Backend), uncomment the FCM and Firebase code in the `Upcoming Rooms Time Checker Function` and add your google-services.json in the folder for that function before setting up the localhost backend.
99
<br/>
1010
1111
### Prerequisits (must be installed) for Backend Env Set-Up
@@ -23,7 +23,7 @@ Clone the [Resonate Backend Repo](https://github.com/AOSSIE-Org/Resonate-Backend
2323
<br/>
2424
2525

26-
Navigate to the root directory of the project in your terminal (for windows power shell), and run the command
26+
Navigate to the root directory of the project in your terminal (for Windows PowerShell), and run the command
2727

2828
##### Linux and MacOS
2929

@@ -72,7 +72,7 @@ Thus my Team Id is `666ce18b003caf6274b6`, enter your team id in the terminal, o
7272

7373

7474
#### Auth Set Up
75-
The auth set up is intentially skipped as google Oauth did not allow private IP as allowed redirect URl's so we had to make the script open tunnels and once tunneling was introduced. It brought more complexities and conditions of working which degraded the scripts robustness
75+
The auth set up is intentionally skipped as google Oauth did not allow private IP as allowed redirect URl's so we had to make the script open tunnels and once tunneling was introduced. It brought more complexities and conditions of working which degraded the scripts robustness
7676

7777
So we have decided to create a dedicated script for the rare case of testing the Oauth login buttons ('google', 'github') this script is work in progress and will be out soon. But for now email password signIn should work perfectly fine enabling you to explore full capabilities of the project with a robust script
7878

@@ -83,7 +83,7 @@ Now you will be prompted for `Collection` Set Up
8383

8484
![Screenshot 2024-07-06 at 5 14 46 PM](https://github.com/Aarush-Acharya/Resonate/assets/92685647/5155b124-07e4-4769-a9f1-ac574816f85e)
8585

86-
Press "a" to select all and press enter, same goes for `Buckets` set up comming after this. The `Functions` will be pushed at then end of the script after the Livekit env vars are pushed as the Function need redeployment after a new env var is pushed in order to read the var.
86+
Press "a" to select all and press enter, same goes for `Buckets` set up coming after this. The `Functions` will be pushed at the end of the script after the Livekit env vars are pushed as the Functions need redeployment after a new env var is pushed in order to read the var.
8787

8888
This completes the Resonate project Set Up (functions will be pushed in the end) in your local Appwrite Instance 🚀🍀
8989
<br/>

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ With social voice platforms like Spotify, Clubhouse, and Twitter Spaces experien
4545
1. Real-time Audio Communication by joining rooms and talking to people.
4646
2. Ability to create rooms and moderate speakers and events.
4747
3. Create Scheduled Rooms and notify subscribers as reminders to join
48-
4. Listen to and Stories as chapters with synced lyrics, browse through entire catalog of stories following your favourate creators and waiting for their latest chapter/story releases. Post your own stories having chapters. (work in progess)
48+
4. Listen to and create Stories as chapters with synced lyrics, browse through entire catalog of stories following your favorite creators and waiting for their latest chapter/story releases. Post your own stories having chapters.
4949
5. Pair chatting to enable users to find random partners to talk to in the app.
5050
6. Friend People/Profiles enabling your self to talk on voice calls/realtime messaging with them (coming soon)
5151

@@ -62,10 +62,10 @@ With social voice platforms like Spotify, Clubhouse, and Twitter Spaces experien
6262

6363
## :four_leaf_clover: Getting Started
6464

65-
Resonate is a wide project taking use of other software solutions like Appwrite and Livekit, starting up can be a little challenging
65+
Resonate is a broad project that makes use of other software solutions like Appwrite and Livekit, starting up can be a little challenging.
6666

6767
We offer a guide for walking you through setting up the entire project, including a script that automates the set up of the backend environment for you.
68-
Please go through and strictly follow the [Onboarding Guide](https://github.com/AOSSIE-Org/Resonate/blob/master/ONBOARDING.md) for setting up the project for development and further contribution
68+
Please go through and strictly follow the [Onboarding Guide](https://github.com/AOSSIE-Org/Resonate/blob/master/ONBOARDING.md) for setting up the project for development and further contributions.
6969

7070
## ▶️ Play Store Feature Graphic
7171

@@ -96,7 +96,7 @@ Please go through and strictly follow the [Onboarding Guide](https://github.com/
9696

9797
:star: Don't forget to star this repository if you find it useful! :star:
9898

99-
Thank you for considering contributing to this project! Contributions are highly appreciated and welcomed (P.S. to the `dev` branch). To ensure a smooth collaboration, Refer to the [Contribution Guidelines](https://github.com/AOSSIE-Org/Resonate/blob/master/CONTRIBUTING.md).
99+
Thank you for considering contributing to this project! Contributions are highly appreciated and welcomed. (Please contribute to the `dev` branch.) To ensure smooth collaboration, refer to the Contribution Guidelines(https://github.com/AOSSIE-Org/Resonate/blob/master/CONTRIBUTING.md).
100100

101101
We appreciate your contributions and look forward to working with you to make this project even better!
102102

0 commit comments

Comments
 (0)