Skip to content

Commit 13bf912

Browse files
authored
Revert "FWF-6254-task-listing-for-direct-assignees"
1 parent 89cf8a6 commit 13bf912

File tree

4 files changed

+22
-58
lines changed

4 files changed

+22
-58
lines changed

forms-flow-review/src/components/TaskFilterModal/TaskFilterModalBody.tsx

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -162,15 +162,9 @@ const TaskFilterModalBody = ({
162162

163163
const getCriteria = () => {
164164
const criteria: FilterCriteria = {
165-
orQueries: [
166-
{
167-
candidateGroupsExpression: "${currentUserGroups()}",
168-
includeAssignedTasks: true,
169-
},
170-
{
171-
assigneeExpression: "${currentUser()}",
172-
},
173-
],
165+
includeAssignedTasks: true,
166+
candidateGroupsExpression: "${currentUserGroups()}",
167+
// If sorting is based on submission id or form name, that should be passed as process variable in sorting
174168
sorting: sortValue === "applicationId" || sortValue === "formName" ?
175169
([{
176170
sortBy: "processVariable", sortOrder: sortOrder,
@@ -179,6 +173,8 @@ const TaskFilterModalBody = ({
179173
[{ sortBy: sortValue, sortOrder: sortOrder }],
180174
};
181175

176+
177+
182178
if (selectedForm?.formId) {
183179
criteria.processVariables = [];
184180
criteria.processVariables.push({
@@ -189,24 +185,20 @@ const TaskFilterModalBody = ({
189185
}
190186

191187
if (accessOption === SPECIFIC_ROLE) {
192-
const trimmedAccessValue = trimFirstSlash(accessValue);
193-
const candidateGroup = addTenantPrefixIfNeeded(
194-
trimmedAccessValue,
195-
tenantKey,
196-
MULTITENANCY_ENABLED
197-
);
198-
criteria.orQueries = [
199-
{
200-
candidateGroup: candidateGroup,
201-
includeAssignedTasks: true,
202-
},
203-
{
204-
assigneeExpression: "${currentUser()}",
205-
},
206-
];
207-
} else if (accessOption === SPECIFIC_ASSIGNEE) {
208-
delete criteria.orQueries;
188+
const trimmedAccessValue = trimFirstSlash(accessValue);
189+
criteria.candidateGroup = addTenantPrefixIfNeeded(
190+
trimmedAccessValue,
191+
tenantKey,
192+
MULTITENANCY_ENABLED
193+
);
194+
delete criteria.assignee;
195+
} else if(accessOption === SPECIFIC_ASSIGNEE){
209196
criteria.assignee = accessValue;
197+
delete criteria.candidateGroup;
198+
}
199+
else{
200+
delete criteria.assignee;
201+
delete criteria.candidateGroup;
210202
}
211203

212204
return criteria;

forms-flow-review/src/constants/allTasksPayload.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,8 @@ const useAllTasksPayload = () => {
99
return {
1010
name: "All Tasks",
1111
criteria: {
12-
orQueries: [
13-
{
14-
candidateGroupsExpression: "${currentUserGroups()}",
15-
includeAssignedTasks: true,
16-
},
17-
{
18-
assigneeExpression: "${currentUser()}",
19-
},
20-
],
12+
includeAssignedTasks: true,
13+
candidateGroupsExpression: "${currentUserGroups()}",
2114
sorting: [
2215
{
2316
sortBy: "created",

forms-flow-review/src/helper/taskHelper.ts

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -82,29 +82,10 @@ export const createReqPayload = (
8282
};
8383

8484
const date = buildDateRangePayload(dateRange);
85-
86-
const criteria = clonedFilter?.criteria || {};
87-
88-
// Transform old-format filters (without orQueries) to use orQueries
89-
// so that tasks directly assigned to the user are also returned.
90-
if (!criteria.orQueries && criteria.candidateGroupsExpression) {
91-
criteria.orQueries = [
92-
{
93-
candidateGroupsExpression: criteria.candidateGroupsExpression,
94-
includeAssignedTasks: true,
95-
},
96-
{
97-
assigneeExpression: "${ currentUser() }",
98-
},
99-
];
100-
delete criteria.candidateGroupsExpression;
101-
delete criteria.includeAssignedTasks;
102-
}
103-
10485
const updatedFilter = {
10586
...clonedFilter,
10687
criteria: {
107-
...criteria,
88+
...clonedFilter?.criteria,
10889
...(processVariables.processVariables?.length && processVariables),
10990
...(assignee.assignee && assignee),
11091
...date,

forms-flow-review/src/types/taskFilter.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@ export interface FilterCriteria {
44
includeAssignedTasks?: boolean;
55
candidateGroup?: string;
66
assignee?: string;
7-
assigneeExpression?: string;
87
processVariables?: Array<{
98
name: string;
109
operator: string;
1110
value: string;
1211
}>;
13-
candidateGroupsExpression?: string;
14-
orQueries?: Array<Record<string, any>>;
12+
candidateGroupsExpression: string;
1513
sorting: Array<{
1614
}>;
1715
createdAfter?: string;

0 commit comments

Comments
 (0)