You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No sensitive information (keys, passwords, secrets) committed
I have updated the CHANGELOG with relevant details
I have given a clear and meaningful PR title and description
I have verified cross-repo dependencies (if any)
I have confirmed backward compatibility with previous releases
Verified changes across all selected microfrontends
👥 Reviewer Notes
PR Type
Enhancement
Description
Add icons for error states
Style guide panel URL errors
Style API error text blocks
Clean SmallSearchIcon formatting
Diagram Walkthrough
flowchart LR
A["`SvgIcons/index.tsx`"]
B["Error-state icons"]
C["`_aiFormBuilder.scss`"]
D["URL and API error styles"]
A -- "adds" --> B
C -- "styles" --> D
B -- "supports" --> D
AccessRestrictedIcon and CautionIcon accept ...props but never pass them to the root <svg>. Any caller-provided className, style, data-testid, aria-*, or event handlers will be silently ignored, which makes these icons hard to style, test, or mark up accessibly when they are rendered in the new error screens.
Both new icon components take a color prop but hardcode their fill/stroke values instead of using it. If a screen tries to reuse these icons with a different theme color or state color, the icon will always render in the fixed palette from this file.
Latest suggestions up to c95fe28
Explore these optional code suggestions:
Category
Suggestion
Impact
General
Forward icon customization props
AccessRestrictedIcon destructures color and props but never applies them, so callers cannot override the icon color or pass accessibility and test attributes to the rendered SVG. Forward {...props} to the and use color as the source of both fill and stroke with a default fallback.
Why: The suggestion is accurate because AccessRestrictedIcon currently ignores both color and props, which prevents callers from customizing the icon or passing SVG attributes like accessibility and test props. This improves reusability in forms-flow-components/src/components/SvgIcons/index.tsx, but it is not a critical correctness issue.
Low
Possible issue
Remove shared SVG id
The fixed clipPath id will collide when multiple CautionIcon instances are mounted, and because the clip just covers the full canvas it is unnecessary anyway. Remove the wrapper and defs entirely, then forward {...props} and use color so the icon remains customizable without shared DOM ids.
Why: The suggestion is mostly correct: CautionIcon uses a fixed clipPath id and also ignores color and props, while the full-canvas clip appears unnecessary. The id collision risk is fairly low here because the clip definition is identical, so this is a moderate robustness and customization improvement rather than an important bug fix.
Convert the SVG attributes to React's camelCase equivalents. clip-path and fill-opacity are invalid JSX prop names, so the clipping and transparency can fail when this icon renders.
Why: This correctly identifies multiple JSX-incompatible SVG attributes in CautionIcon, including clip-path and fill-opacity, and the improved_code matches the intended fix. It can prevent invalid DOM property warnings and potential issues with clipping/transparency, so it has moderate impact.
Medium
Fix invalid SVG prop
Replace the kebab-case SVG prop with the JSX-safe camelCase form. Using stroke-width in React can be ignored or trigger invalid DOM property warnings, which would leave the icon stroke rendering incorrectly.
Why: The suggestion is accurate: stroke-width should be strokeWidth in React JSX for the AccessRestrictedIcon SVG. This is a real rendering/console-warning issue, but it is limited in scope to a single icon prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
📝 Pull Request Summary
Description:
styles added for the error screens
Related Jira Ticket:
https://aottech.atlassian.net/browse/FWF-6183
Type of Change:
🧩 Microfrontends Affected
Please select all microfrontends or modules that are part of this change:
Details (if Others selected):
🧠 Summary of Changes
🧪 Testing Details
Testing Performed:
Screenshots (if applicable):
✅ Checklist
👥 Reviewer Notes
PR Type
Enhancement
Description
Add icons for error states
Style guide panel URL errors
Style API error text blocks
Clean
SmallSearchIconformattingDiagram Walkthrough
File Walkthrough
index.tsx
Add reusable icons for error screensforms-flow-components/src/components/SvgIcons/index.tsx
SmallSearchIconfor readabilityAccessRestrictedIconSVG componentCautionIconSVG component_aiFormBuilder.scss
Add AI builder error screen stylesforms-flow-theme/scss/v8-scss/_aiFormBuilder.scss
$font-weight-mediumtoken mapping$gray-darkest-90helper color