Skip to content

Commit ce28714

Browse files
committed
Fix lint warnings inside Dockerfiles
1 parent e8af7d7 commit ce28714

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

example/express-server/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ COPY ./graphql-voyager-*.tgz graphql-voyager.tgz
88

99
COPY ./example/express-server ./example/express-server
1010

11-
WORKDIR example/express-server
11+
WORKDIR /app/example/express-server
1212
RUN npm install
1313
RUN npm test
1414

example/webpack/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# syntax=docker/dockerfile:1
22

3-
FROM node:20
3+
FROM node:24
44

55
WORKDIR /app
66

77
COPY ./graphql-voyager-*.tgz graphql-voyager.tgz
88

99
COPY ./example/webpack ./example/webpack
1010

11-
WORKDIR example/webpack
11+
WORKDIR /app/example/webpack
1212
RUN npm install
1313
RUN npm test
1414

worker/Dockerfile

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,28 @@ ENV GRAPHVIZ_VERSION=8.0.1
66
ENV EXPAT_VERSION=2.5.0
77
ENV USE_CLOSURE=0
88

9+
# Since bellow RUN commands use pipes set "pipefail"
10+
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
11+
912
WORKDIR /home/build/deps
1013

1114
RUN EXPAT_SOURCE_URL="https://github.com/libexpat/libexpat/releases/download/R_$(echo ${EXPAT_VERSION} | tr . _)/expat-${EXPAT_VERSION}.tar.xz"; \
1215
curl --fail --location "$EXPAT_SOURCE_URL" | tar -xJ
1316
RUN mv expat-${EXPAT_VERSION} expat
14-
WORKDIR expat
17+
WORKDIR /home/build/deps/expat
1518
RUN grep -q ${EXPAT_VERSION} expat_config.h
1619
RUN emconfigure ./configure \
1720
--disable-shared \
1821
--prefix=/home/build \
1922
--libdir=/home/build/lib \
2023
CFLAGS="-Oz -w -flto" LDFLAGS="-Oz -s -flto"
2124
RUN emmake make -j -C lib all install
22-
WORKDIR ..
25+
WORKDIR /home/build/deps
2326

2427
RUN GRAPHVIZ_SOURCE_URL="https://gitlab.com/api/v4/projects/4207231/packages/generic/graphviz-releases/${GRAPHVIZ_VERSION}/graphviz-${GRAPHVIZ_VERSION}.tar.xz"; \
2528
curl --fail --location "$GRAPHVIZ_SOURCE_URL" | tar -xJ
2629
RUN mv "graphviz-${GRAPHVIZ_VERSION}" graphviz
27-
WORKDIR graphviz
30+
WORKDIR /home/build/deps/graphviz
2831
RUN grep -q "${GRAPHVIZ_VERSION}" graphviz_version.h
2932
RUN emconfigure ./configure \
3033
--without-sfdp \
@@ -38,7 +41,7 @@ RUN emconfigure ./configure \
3841
RUN emmake make -j lib plugin
3942
RUN emmake make -j -C lib install
4043
RUN emmake make -j -C plugin install
41-
WORKDIR ..
44+
WORKDIR /home/build/deps
4245

4346
WORKDIR /home
4447

0 commit comments

Comments
 (0)