Skip to content

Commit 5f49261

Browse files
committed
disable the non-rdap-specific tests for now
1 parent 8ef4bc7 commit 5f49261

File tree

1 file changed

+44
-37
lines changed

1 file changed

+44
-37
lines changed

src/main/java/net/apnic/rdap/conformance/Application.java

Lines changed: 44 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,45 @@ private static Result getDocRefProto(String document,
8888
return proto;
8989
}
9090

91+
private static void runNonRdapTests(List<Test> tests)
92+
{
93+
/* Relative URI in the HTTP request. */
94+
Result relative = new Result();
95+
relative.setTestName("common.bad-uri-relative");
96+
relative.setStatus(Result.Status.Notification);
97+
tests.add(
98+
new net.apnic.rdap.conformance.test.common.RawURIRequest(
99+
"domain/example.com",
100+
relative,
101+
false
102+
)
103+
);
104+
105+
/* Unprintable characters in the URI in the HTTP request. */
106+
Result unprintable = new Result();
107+
unprintable.setTestName("common.bad-uri-unprintable");
108+
unprintable.setStatus(Result.Status.Notification);
109+
tests.add(
110+
new net.apnic.rdap.conformance.test.common.RawURIRequest(
111+
"/domain/" + new String(Character.toChars(0)),
112+
unprintable,
113+
false
114+
)
115+
);
116+
117+
/* Absolute URI in the HTTP request. */
118+
Result absolute = new Result();
119+
absolute.setTestName("common.uri-absolute");
120+
absolute.setStatus(Result.Status.Notification);
121+
tests.add(
122+
new net.apnic.rdap.conformance.test.common.RawURIRequest(
123+
c.getSpecification().getBaseUrl() + "/domain/example.com",
124+
absolute,
125+
true
126+
)
127+
);
128+
}
129+
91130
/**
92131
* <p>main.</p>
93132
*
@@ -161,43 +200,11 @@ public X509Certificate[] getAcceptedIssuers() {
161200

162201
List<Test> tests = new ArrayList();
163202

164-
/* Relative URI in the HTTP request. */
165-
Result relative = new Result();
166-
relative.setTestName("common.bad-uri-relative");
167-
relative.setStatus(Result.Status.Notification);
168-
tests.add(
169-
new net.apnic.rdap.conformance.test.common.RawURIRequest(
170-
"domain/example.com",
171-
relative,
172-
false
173-
)
174-
);
175-
176-
/* Unprintable characters in the URI in the HTTP request. */
177-
Result unprintable = new Result();
178-
unprintable.setTestName("common.bad-uri-unprintable");
179-
unprintable.setStatus(Result.Status.Notification);
180-
tests.add(
181-
new net.apnic.rdap.conformance.test.common.RawURIRequest(
182-
"/domain/" + new String(Character.toChars(0)),
183-
unprintable,
184-
false
185-
)
186-
);
187-
188-
/* Absolute URI in the HTTP request. */
189-
Result absolute = new Result();
190-
absolute.setTestName("common.uri-absolute");
191-
tests.add(
192-
new net.apnic.rdap.conformance.test.common.RawURIRequest(
193-
c.getSpecification().getBaseUrl() + "/domain/example.com",
194-
absolute,
195-
true
196-
)
197-
);
198-
199-
/* From here onwards, the tests are RDAP-specific, except for
200-
* the unescaped-URI IP test. */
203+
/* For now, the non-RDAP-specific tests are disabled. These
204+
* are fairly niche, and in many cases can't easily be fixed
205+
* by implementers anyway. See e.g.
206+
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=414636. */
207+
// runNonRdapTests(tests);
201208

202209
/* application/json content-type. This is deliberately using
203210
* an invalid status code with inverted sense, because so long

0 commit comments

Comments
 (0)