Skip to content

Commit bef9cad

Browse files
committed
- fix: remove parameter assetParam.isValid
1 parent 627236e commit bef9cad

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

docs/package.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ new Package({
1111
assetFile: yourAssetFile, // read details after this code block
1212
assetName: 'model.gltf', // the AR asset filename, including the file extension
1313
assetParam: {
14-
isValid: true, // whether the scale/size parameters are correct or not (if you don't know what this is, set to true)
1514
scale: 1.0, // scale of the asset
1615
size: { // sizes of the asset, unused
1716
width: 1.0,
@@ -88,7 +87,6 @@ const package = new Package({
8887
assetFile: base64Asset,
8988
assetName: file.name,
9089
assetParam: {
91-
isValid: true,
9290
scale: 1.0
9391
},
9492
markerPatt: textPatt

src/modules/package/Package.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@ export const PACKAGE_GITHUB = 'github';
2323

2424
/**
2525
* @typedef AssetParam
26-
* @property {boolean} isValid
2726
* @property {Number} scale
2827
* @property {{width: Number, height: Number, depth: Number}} size
2928
* @property {Array<{latitude: Number, longitude: Number}>} locations - an array of latitude/longitude locations, for location based AR
3029
*/
3130
const defaultAssetParam = {
32-
isValid: true,
3331
scale: 1.0,
3432
size: {
3533
width: 1.0,
@@ -56,11 +54,7 @@ export class Package {
5654
this.assetFile = config.assetFile;
5755
this.assetName = config.assetName;
5856
this.assetParam = config.assetParam || defaultAssetParam;
59-
60-
if (!this.assetParam.isValid) {
61-
throw new Error('Asset parameters are not valid');
62-
}
63-
57+
6458
this.config = config;
6559
}
6660

0 commit comments

Comments
 (0)