You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Contributions are accepted at <a href="https://github.com/arm-software/ComputeLibrary">arm-software/ComputeLibrary</a>.
37
34
38
35
@section S5_0_inc_lang Inclusive language guideline
39
36
As part of the initiative to use inclusive language, there are certain phrases and words that were removed or replaced by more inclusive ones. Examples include but not limited to:
@@ -481,22 +478,9 @@ void DoNewThing();
481
478
482
479
@section S5_2_how_to_submit_a_patch How to submit a patch
483
480
484
-
To be able to submit a patch to our development repository you need to have a GitHub account. With that, you will be able to sign in to Gerrit where your patch will be reviewed.
485
-
486
-
Next step is to clone the Compute Library repository:
@@ -507,22 +491,19 @@ You can add this to your patch with:
507
491
508
492
git commit -s --amend
509
493
510
-
You are now ready to submit your patch for review:
511
-
512
-
git push acl-gerrit HEAD:refs/for/main
494
+
You are now ready to submit your patch for review in a pull request.
513
495
514
496
@section S5_3_code_review Patch acceptance and code review
515
497
516
-
Once a patch is uploaded for review, there is a pre-commit test that runs on a Jenkins server for continuous integration tests. In order to be merged a patch needs to:
498
+
Once a patch is uploaded for review, there is a pre-commit test that runs on a Jenkins server for continuous integration tests.
499
+
In order to be merged, a patch needs to:
517
500
518
-
- get a "+1 Verified" from the pre-commit job
519
-
- get a "+1 Comments-Addressed", in case of comments from reviewers the committer has to address them all. A comment is considered addressed when the first line of the reply contains the word "Done"
520
-
- get a "+2" from a reviewer, that means the patch has the final approval
501
+
- pass the pre-commit job,
502
+
- be squashed,
503
+
- be approved by a Compute Library maintainer.
521
504
522
505
At the moment, the Jenkins server is not publicly accessible and for security reasons patches submitted by non-allowlisted committers do not trigger the pre-commit tests. For this reason, one of the maintainers has to manually trigger the job.
523
506
524
-
If the pre-commit test fails, the Jenkins job will post a comment on Gerrit with the details about the failure so that the committer will be able to reproduce the error and fix the issue, if any (sometimes there can be infrastructure issues, a test platform disconnecting for example, where the job needs to be retriggered).
0 commit comments