Skip to content

Commit 3c32d70

Browse files
committed
fix: Added tolerance to tests failing the nightly build.
A larger tolerance is required for quantized (integer) data types. Resolves: COMPMID-8494 Signed-off-by: Anna Mayne <[email protected]> Signed-off-by: Anna Mayne <[email protected]> Change-Id: I63232606a0cd93f52a307eb928e56bd06082ea8e Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/15022 Tested-by: Arm Jenkins <[email protected]> Reviewed-by: Pablo Marquez Tello <[email protected]> Benchmark: Arm Jenkins <[email protected]> Comments-Addressed: Arm Jenkins <[email protected]>
1 parent aca26c7 commit 3c32d70

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

tests/validation/runtime/experimental/operators/CpuGEMMLowp.cpp

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,15 @@ namespace test
4646
{
4747
namespace validation
4848
{
49+
namespace
50+
{
4951
using framework::dataset::make;
5052

53+
/** Tolerance for float operations */
54+
constexpr AbsoluteTolerance<int8_t> tolerance_qasymm8_signed(1);
55+
constexpr AbsoluteTolerance<uint8_t> tolerance_qasymm8(1);
56+
} // namespace
57+
5158
TEST_SUITE(NEON)
5259
TEST_SUITE(OPERATORS)
5360
TEST_SUITE(CpuGEMMLowp)
@@ -251,15 +258,15 @@ TEST_SUITE(QASYMM8)
251258
FIXTURE_DATA_TEST_CASE(SmokeTestStaticQuant, CpuGEMMLowpStaticQuantFixture, framework::DatasetMode::ALL, combine(datasets::SmallGEMMLowpDataset(), make("DataType", DataType::QASYMM8), make("bool", false)/*is_multithreaded*/))
252259
{
253260
// Validate output
254-
validate(Accessor(_targets[0]), _references[0]);
261+
validate(Accessor(_targets[0]), _references[0], tolerance_qasymm8);
255262
}
256263
TEST_SUITE_END() // QASYMM8
257264

258265
TEST_SUITE(QASYMM8_SIGNED)
259266
FIXTURE_DATA_TEST_CASE(SmokeTestStaticQuant, CpuGEMMLowpStaticQuantFixture, framework::DatasetMode::ALL, combine(datasets::SmallGEMMLowpDataset(), make("DataType", DataType::QASYMM8_SIGNED), make("bool", false)/*is_multithreaded*/))
260267
{
261268
// Validate output
262-
validate(Accessor(_targets[0]), _references[0]);
269+
validate(Accessor(_targets[0]), _references[0], tolerance_qasymm8_signed);
263270
}
264271
TEST_SUITE_END() // QASYMM8_SIGNED
265272

@@ -270,7 +277,7 @@ FIXTURE_DATA_TEST_CASE(ConfigureOnceUseFromDifferentThreads, CpuGEMMLowpStaticQu
270277
// Validate output
271278
for(int i = 0; i < _num_parallel_runs; ++i)
272279
{
273-
validate(Accessor(_targets[i]), _references[i]);
280+
validate(Accessor(_targets[i]), _references[i], tolerance_qasymm8_signed);
274281
}
275282
}
276283
TEST_SUITE_END() // ThreadSafety

0 commit comments

Comments
 (0)