Skip to content

Commit 11f7cf9

Browse files
authored
[libcxx] Remove xfails for char16_t (#551)
picolibc added support for `char16_t` on trunk. However we can't yet remove the xfails in upstream because it firstly needs to pick up on a picolibc release that includes that support. This is a patch which must be upstreamed once llvm-project updates its picolibc version to one that has `char16_t` support.
1 parent 4a2939f commit 11f7cf9

File tree

1 file changed

+47
-0
lines changed

1 file changed

+47
-0
lines changed
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
From 2c6b08baa20bb4a7e4a936ecf286a1c9e1f0f8c9 Mon Sep 17 00:00:00 2001
2+
From: Victor Campos <[email protected]>
3+
Date: Thu, 31 Oct 2024 14:03:58 +0000
4+
Subject: [libcxx] Remove xfails due to picolibc's support for char16_t and
5+
char32_t
6+
7+
picolibc recently
8+
([link](https://github.com/picolibc/picolibc/commit/f6f68758fe2aa62854f49b90c3daeeb08242b512))
9+
added support for char16_t and char32_t.
10+
11+
These xfails aren't needed anymore.
12+
---
13+
libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp | 3 ---
14+
libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp | 3 ---
15+
2 files changed, 6 deletions(-)
16+
17+
diff --git a/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp b/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp
18+
index a1560c8ee585..2b6455466681 100644
19+
--- a/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp
20+
+++ b/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp
21+
@@ -11,9 +11,6 @@
22+
// Apple platforms don't provide <uchar.h> yet, so these tests fail.
23+
// XFAIL: target={{.+}}-apple-{{.+}}
24+
25+
-// mbrtoc16 not defined.
26+
-// XFAIL: LIBCXX-PICOLIBC-FIXME
27+
-
28+
// <uchar.h>
29+
30+
#include <uchar.h>
31+
diff --git a/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp b/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp
32+
index 2076384deb2b..db00cbde3336 100644
33+
--- a/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp
34+
+++ b/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp
35+
@@ -11,9 +11,6 @@
36+
// Apple platforms don't provide <uchar.h> yet, so these tests fail.
37+
// XFAIL: target={{.+}}-apple-{{.+}}
38+
39+
-// mbrtoc16 not defined.
40+
-// XFAIL: LIBCXX-PICOLIBC-FIXME
41+
-
42+
// <cuchar>
43+
44+
#include <cuchar>
45+
--
46+
2.43.0
47+

0 commit comments

Comments
 (0)