Skip to content

Commit 8139c96

Browse files
authored
Fix build failures in aarch64a_[be_]soft_nofp variants. (#591)
Those two variants have `-fno-exceptions -fno-rtti` in the configuration file that specifies options for building the library. None of the other library variants is built with this flags, not even the other variants intended for use in _applications_ without exceptions and RTTI. If you try to build libc++abi with those flags, it fails to build, because `private_typeinfo.cpp` is unconditionally included in the library and unconditionally uses `dynamic_cast`. (And I assume that it's OK to use `dynamic_cast` in that part of libc++abi if the application will never use RTTI, because then it won't include that object file in the first place.)
1 parent 938676c commit 8139c96

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

arm-multilib/json/variants/aarch64a_be_soft_nofp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"common": {
44
"TARGET_ARCH": "aarch64a",
55
"VARIANT": "aarch64a_be_soft_nofp",
6-
"COMPILE_FLAGS": "-march=armv8-a+nofp+nosimd -mbig-endian -mabi=aapcs-soft -mno-unaligned-access -fno-exceptions -fno-rtti",
6+
"COMPILE_FLAGS": "-march=armv8-a+nofp+nosimd -mbig-endian -mabi=aapcs-soft -mno-unaligned-access",
77
"ENABLE_EXCEPTIONS": "OFF",
88
"ENABLE_RTTI": "OFF",
99
"TEST_EXECUTOR": "fvp",

arm-multilib/json/variants/aarch64a_soft_nofp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"common": {
44
"TARGET_ARCH": "aarch64a",
55
"VARIANT": "aarch64a_soft_nofp",
6-
"COMPILE_FLAGS": "-march=armv8-a+nofp+nosimd -mabi=aapcs-soft -mno-unaligned-access -fno-exceptions -fno-rtti",
6+
"COMPILE_FLAGS": "-march=armv8-a+nofp+nosimd -mabi=aapcs-soft -mno-unaligned-access",
77
"ENABLE_EXCEPTIONS": "OFF",
88
"ENABLE_RTTI": "OFF",
99
"TEST_EXECUTOR": "qemu",

0 commit comments

Comments
 (0)