Skip to content

Commit 8cfc242

Browse files
committed
Reinstate armv4t and armv5te compiler_rt and libcxx tests
Pull request #109628 automatically turned on frame pointers for leaf functions in Clang when frame pointers are enabled. This triggered a latent bug in picolibc for armv4t and armv5te, which consequentially broke our tests for them. There is currently a pull request that fixes this bug (picolibc/picolibc#897), but we don't have to wait for this to merge to reinstate the tests, because we recently changed the behaviour of Clang to by default omit frame pointers altogether (llvm/llvm-project#117140), and that is how picolibc is built now. In general the advice is that you shouldn't build AArch32 targets with frame pointers enabled for various reasons.
1 parent 59f5919 commit 8cfc242

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

arm-multilib/json/variants/armv4t.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
"picolibc": {
2222
"PICOLIBC_BUILD_TYPE": "minsize",
2323
"ENABLE_CXX_LIBS": "ON",
24-
"ENABLE_LIBC_TESTS": "OFF",
25-
"ENABLE_COMPILER_RT_TESTS": "OFF",
26-
"ENABLE_LIBCXX_TESTS": "OFF"
24+
"ENABLE_LIBC_TESTS": "ON",
25+
"ENABLE_COMPILER_RT_TESTS": "ON",
26+
"ENABLE_LIBCXX_TESTS": "ON"
2727
},
2828
"newlib": {
2929
"ENABLE_CXX_LIBS": "ON",
@@ -38,4 +38,4 @@
3838
"ENABLE_LIBCXX_TESTS": "OFF"
3939
}
4040
}
41-
}
41+
}

arm-multilib/json/variants/armv5te.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
"picolibc": {
2222
"PICOLIBC_BUILD_TYPE": "minsize",
2323
"ENABLE_CXX_LIBS": "ON",
24-
"ENABLE_LIBC_TESTS": "OFF",
25-
"ENABLE_COMPILER_RT_TESTS": "OFF",
26-
"ENABLE_LIBCXX_TESTS": "OFF"
24+
"ENABLE_LIBC_TESTS": "ON",
25+
"ENABLE_COMPILER_RT_TESTS": "ON",
26+
"ENABLE_LIBCXX_TESTS": "ON"
2727
},
2828
"newlib": {
2929
"ENABLE_CXX_LIBS": "ON",
@@ -38,4 +38,4 @@
3838
"ENABLE_LIBCXX_TESTS": "OFF"
3939
}
4040
}
41-
}
41+
}

0 commit comments

Comments
 (0)