From 263b5c96f89c5d3861f5dd737aa9e800e9b1f630 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Fri, 1 Nov 2024 09:58:54 +0000 Subject: [PATCH] [libcxx] Remove xfails for char16_t picolibc added support for `char16_t` on trunk. However we can't yet remove the xfails in upstream because it firstly needs to pick up on a picolibc release that includes that support. This is a patch which must be upstreamed once llvm-project updates its picolibc version to one that has `char16_t` support. --- ...ails-due-to-picolibc-s-support-for-c.patch | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 patches/llvm-project/0007-libcxx-Remove-xfails-due-to-picolibc-s-support-for-c.patch diff --git a/patches/llvm-project/0007-libcxx-Remove-xfails-due-to-picolibc-s-support-for-c.patch b/patches/llvm-project/0007-libcxx-Remove-xfails-due-to-picolibc-s-support-for-c.patch new file mode 100644 index 00000000..0929944a --- /dev/null +++ b/patches/llvm-project/0007-libcxx-Remove-xfails-due-to-picolibc-s-support-for-c.patch @@ -0,0 +1,47 @@ +From 2c6b08baa20bb4a7e4a936ecf286a1c9e1f0f8c9 Mon Sep 17 00:00:00 2001 +From: Victor Campos +Date: Thu, 31 Oct 2024 14:03:58 +0000 +Subject: [libcxx] Remove xfails due to picolibc's support for char16_t and + char32_t + +picolibc recently +([link](https://github.com/picolibc/picolibc/commit/f6f68758fe2aa62854f49b90c3daeeb08242b512)) +added support for char16_t and char32_t. + +These xfails aren't needed anymore. +--- + libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp | 3 --- + libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp | 3 --- + 2 files changed, 6 deletions(-) + +diff --git a/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp b/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp +index a1560c8ee585..2b6455466681 100644 +--- a/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp ++++ b/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp +@@ -11,9 +11,6 @@ + // Apple platforms don't provide yet, so these tests fail. + // XFAIL: target={{.+}}-apple-{{.+}} + +-// mbrtoc16 not defined. +-// XFAIL: LIBCXX-PICOLIBC-FIXME +- + // + + #include +diff --git a/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp b/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp +index 2076384deb2b..db00cbde3336 100644 +--- a/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp ++++ b/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp +@@ -11,9 +11,6 @@ + // Apple platforms don't provide yet, so these tests fail. + // XFAIL: target={{.+}}-apple-{{.+}} + +-// mbrtoc16 not defined. +-// XFAIL: LIBCXX-PICOLIBC-FIXME +- + // + + #include +-- +2.43.0 +