[Perf] Update inlining memcpy patch #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch file for setting inilining memcpy preference was slightly incorrect. Use of the SmallVector data structure caused issues with correctly inlining on some tests. The optimisation was also not enabled for v8.1m mainline targets as it should be. I've updated the patch file to reflect this. Change-Id: Ib7e406f7b08d5928eb8ed8d6d98eb1844fef7fd2
nasherm
force-pushed
the
nashe/update-memcpy-patch
branch
from
3c24c8d to
81f982e
Compare
- Gate inline behind a feature flag "inline-memcpy-ld-st" - Add lit test Change-Id: I1ae8a6979de7ce3988d87a4ba2e6d71ebb6b0048
Change-Id: I1b4a534ffb626e5e8b1532ac5a31d377c21c41ae
Change-Id: I584d588378336f90193f981bcff6be8c4e83a205
VladiKrapp-Arm
approved these changes
Nov 14, 2024
Collaborator
VladiKrapp-Arm
left a comment
VladiKrapp-Arm
left a comment
There was a problem hiding this comment.
LGTM
You could also document the flag in docs/optimization-flags.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch file for setting inilining memcpy preference was slightly incorrect. Use of the SmallVector data structure caused issues with correctly inlining on some tests. The optimisation was also not enabled for v8.1m mainline targets as it should be. I've updated the patch file to reflect this.