Skip to content

Conversation

@pratlucas
Copy link
Collaborator

This introduces new library variants for aarch64 to support targets
where unaligned memory accesses are disabled.
To enable these changes a patch to picolibc was required, ensuring the
assembly implemenation that relies on unaligned accesses is not used
when __ARM_FEATURE_UNALIGNED is not defined.

This introduces new library variants for aarch64 to support targets
where unaligned memory accesses are disabled.
To enable these changes a patch to picolibc was required, ensuring the
assembly implemenation that relies on unaligned accesses is not used
when `__ARM_FEATURE_UNALIGNED` is not defined.
@pratlucas pratlucas requested a review from simpal01 November 15, 2024 16:37
Copy link
Collaborator

@simpal01 simpal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simpal01 added a commit to simpal01/LLVM-embedded-toolchain-for-Arm that referenced this pull request Nov 18, 2024
I had changes in CMakeLists.txt to use the correct bootcode.
This is no longer needed as it is already adding through a
different patch:
 ARM-software#567
@pratlucas
Copy link
Collaborator Author

Abandoning this PR in favour of #572.

@pratlucas pratlucas closed this Nov 25, 2024
@pratlucas pratlucas deleted the no-unaligned-access branch November 25, 2024 11:37
simpal01 added a commit that referenced this pull request Nov 26, 2024
This introduces new library variants for aarch64 to support targets
where unaligned memory accesses are disabled.
To enable these changes a patch to picolibc was required, ensuring the
assembly implemenation that relies on unaligned accesses is not used
when __ARM_FEATURE_UNALIGNED is not defined.
Co-authored by: @pratlucas (

(#567)

---------

Co-authored-by: Lucas Prates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants