Skip to content

Conversation

@simpal01
Copy link
Collaborator

This introduces new library variants for aarch64 to support targets
where unaligned memory accesses are disabled.
To enable these changes a patch to picolibc was required, ensuring the
assembly implemenation that relies on unaligned accesses is not used
when __ARM_FEATURE_UNALIGNED is not defined.
Co-authored by: @pratlucas (
(#567)

pratlucas and others added 3 commits November 15, 2024 16:29
This introduces new library variants for aarch64 to support targets
where unaligned memory accesses are disabled.
To enable these changes a patch to picolibc was required, ensuring the
assembly implemenation that relies on unaligned accesses is not used
when `__ARM_FEATURE_UNALIGNED` is not defined.
Copy link
Collaborator

@pratlucas pratlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Adding this patch picolibc/picolibc#874
as a downstream which has the necesary boot code
changes in order for the -mno-unaligned-access to work.
Copy link
Collaborator

@pratlucas pratlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simpal01 simpal01 merged commit 4b047f6 into ARM-software:main Nov 26, 2024
1 check passed
@simpal01 simpal01 deleted the no-unaligned-access branch November 26, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants