Skip to content

Add aarch64 library variants for no-unaligned-access #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Add aarch64 library variants for no-unaligned-access #572

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ced8edd
Add aarch64 library variants for no-unaligned-access
pratlucas Nov 15, 2024
67ed2ba
Merge branch 'main' into no-unaligned-access
simpal01 Nov 19, 2024
0bac691
fixup! Add aarch64 library variants for no-unaligned-access
simpal01 Nov 20, 2024
a59d366
Merge branch 'main' into no-unaligned-access
simpal01 Nov 26, 2024
7514e69
fixup! Merge branch 'main' into no-unaligned-access
simpal01 Nov 26, 2024
3787d94
Merge branch 'main' into no-unaligned-access
simpal01 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions arm-multilib/json/multilib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
"json": "aarch64a.json",
"flags": "--target=aarch64-unknown-none-elf -fno-exceptions -fno-rtti"
},
{
"variant": "aarch64a_strictalign_exn_rtti",
"json": "aarch64a_strictalign_exn_rtti.json",
"flags": "--target=aarch64-unknown-none-elf -mno-unaligned-access"
},
{
"variant": "aarch64a_strictalign",
"json": "aarch64a_strictalign.json",
"flags": "--target=aarch64-unknown-none-elf -mno-unaligned-access -fno-exceptions -fno-rtti"
},
{
"variant": "armv4t_exn_rtti",
"json": "armv4t_exn_rtti.json",
Expand Down
40 changes: 40 additions & 0 deletions arm-multilib/json/variants/aarch64a_strictalign.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"args": {
"common": {
"TARGET_ARCH": "aarch64a",
"VARIANT": "aarch64a_strictalign",
"COMPILE_FLAGS": "-march=armv8-a -mno-unaligned-access",
"ENABLE_EXCEPTIONS": "OFF",
"ENABLE_RTTI": "OFF",
"TEST_EXECUTOR": "fvp",
"FVP_MODEL": "aem-a",
"FVP_CONFIG": "v8a-aarch64",
"BOOT_FLASH_ADDRESS": "0x80000000",
"BOOT_FLASH_SIZE": "0x1000",
"FLASH_ADDRESS": "0x80001000",
"FLASH_SIZE": "0xfff000",
"RAM_ADDRESS": "0x81000000",
"RAM_SIZE": "0x1000000",
"STACK_SIZE": "8K"
},
"picolibc": {
"PICOLIBC_BUILD_TYPE": "release",
"ENABLE_CXX_LIBS": "ON",
"ENABLE_LIBC_TESTS": "ON",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
},
"newlib": {
"ENABLE_CXX_LIBS": "ON",
"ENABLE_LIBC_TESTS": "OFF",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
},
"llvmlibc": {
"ENABLE_CXX_LIBS": "OFF",
"ENABLE_LIBC_TESTS": "OFF",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
}
}
}
40 changes: 40 additions & 0 deletions arm-multilib/json/variants/aarch64a_strictalign_exn_rtti.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"args": {
"common": {
"TARGET_ARCH": "aarch64a",
"VARIANT": "aarch64a_strictalign_exn_rtti",
"COMPILE_FLAGS": "-march=armv8-a -mno-unaligned-access",
"ENABLE_EXCEPTIONS": "ON",
"ENABLE_RTTI": "ON",
"TEST_EXECUTOR": "fvp",
"FVP_MODEL": "aem-a",
"FVP_CONFIG": "v8a-aarch64",
"BOOT_FLASH_ADDRESS": "0x80000000",
"BOOT_FLASH_SIZE": "0x1000",
"FLASH_ADDRESS": "0x80001000",
"FLASH_SIZE": "0xfff000",
"RAM_ADDRESS": "0x81000000",
"RAM_SIZE": "0x1000000",
"STACK_SIZE": "8K"
},
"picolibc": {
"PICOLIBC_BUILD_TYPE": "release",
"ENABLE_CXX_LIBS": "ON",
"ENABLE_LIBC_TESTS": "ON",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
},
"newlib": {
"ENABLE_CXX_LIBS": "ON",
"ENABLE_LIBC_TESTS": "OFF",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
},
"llvmlibc": {
"ENABLE_CXX_LIBS": "OFF",
"ENABLE_LIBC_TESTS": "OFF",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
}
}
}
7 changes: 5 additions & 2 deletions patches/picolibc/0001-Enable-libcxx-builds.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From 42f07bef7775a1387f9707e959f8b6782f9d6808 Mon Sep 17 00:00:00 2001
From 028fe75e045951a9d091008a85971523358160db Mon Sep 17 00:00:00 2001
From: Simi Pallipurath <[email protected]>
Date: Thu, 14 Nov 2024 10:07:08 +0000
Subject: [PATCH 1/2] [PATCH 1/2] Enable libcxx builds
Subject: Enable libcxx builds

Modifications to build config and linker script required to enable
libc++ builds.
Expand Down Expand Up @@ -47,3 +47,6 @@ index 7b63ba172..cda5e1e7e 100644
*(.gnu.linkonce.t.*)
KEEP (*(.fini .fini.*))
@PREFIX@__text_end = .;
--
2.39.5 (Apple Git-154)

7 changes: 3 additions & 4 deletions patches/picolibc/0002-Add-bootcode-for-AArch64-FVPs.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From 3b0b62ce6d81211a71eebe63b4b4ef0732da93ef Mon Sep 17 00:00:00 2001
From 58451642e678817d8822b04b8ff07ee4758a8f10 Mon Sep 17 00:00:00 2001
From: Simi Pallipurath <[email protected]>
Date: Mon, 25 Nov 2024 11:13:50 +0000
Subject: [PATCH 2/2] [PATCH 2/2] Add bootcode for AArch64 FVPs
Date: Thu, 14 Nov 2024 10:12:33 +0000
Subject: Add bootcode for AArch64 FVPs

The AArch64 FVP (Fixed Virtual Platform) models differ from QEMU in a
few ways which affect the crt0 code:
Expand Down Expand Up @@ -886,4 +886,3 @@ index 76965990f..be8f875be 100644
endforeach
--
2.34.1

Loading