CMakeLists.txt: tiny fix to instructions comment. #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpal01
reviewed
Nov 21, 2024
Collaborator
simpal01
left a comment
simpal01
left a comment
There was a problem hiding this comment.
please do relevant changes in docs/building-from-source.md as well.
Now that our downstream picolibc changes are in the form of multiple patches in a subdirectory, it's better to apply them with 'git am' so they turn into separate commits, instead of 'git apply', the same way we do it for llvm-project.
statham-arm
force-pushed
the
git-am-comment-fix
branch
from
b52a51e to
63830f1
Compare
Collaborator
Author
|
Good catch, thanks! |
simpal01
approved these changes
Nov 21, 2024
Laur59
referenced
this pull request
in Laur59/LLVM-embedded-toolchain-for-Arm
Nov 21, 2024
…ranch llvm-20-for-ukos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our downstream picolibc changes are in the form of multiple patches in a subdirectory, it's better to apply them with 'git am' so they turn into separate commits, instead of 'git apply', the same way we do it for llvm-project.