Skip to content

Prevent arm-runtime CMake arguments persisting over loops #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Prevent arm-runtime CMake arguments persisting over loops #587

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dafbb12
Prevent arm-runtime CMake arguments persisting over loops
dcandler Dec 2, 2024
f3982e7
fixup! Prevent arm-runtime CMake arguments persisting over loops
dcandler Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arm-multilib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ foreach(lib_idx RANGE ${lib_count_dec})
set(read_ENABLE_COMPILER_RT_TESTS "OFF")
set(read_ENABLE_LIBCXX_TESTS "OFF")
else()
set(additional_cmake_args "")
Copy link
Contributor

@smithp35 smithp35 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better off above the if statement? That way if another conditional is added then it will automatically pick up a default "".

Copy link
Collaborator Author

@dcandler dcandler Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I've changed it so every loop starts with an empty list, and the args get appended which makes more sense.

# From the json, check which tests are enabled.
foreach(test_enable_var
ENABLE_LIBC_TESTS
Expand Down
Loading