Changes to AArch64 nofp variant #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vhscampos
commented
Dec 6, 2024
vhscampos
commented
- Make the variants strictly aligned
- Create new variant for big endian
- Create new variant for exceptions and RTTI
- Make the variants strictly aligned - Create new variant for big endian - Create new variant for exceptions and RTTI
smithp35
approved these changes
Dec 6, 2024
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
LGTM. I guess that the -mno-unaligned-access isn't present in multilib.json as we don't need to select a variant based on it.
Member
Author
It's not present in order to select these new variants with or without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.