Fix delimiter so CMake reads string as a list #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libraries_supported property is a comma separated list, but CMake uses semi-colons to understand lists. Replacing the character will allow CMake to check which libraries are set within.
statham-arm
approved these changes
Dec 10, 2024
Collaborator
statham-arm
left a comment
statham-arm
left a comment
There was a problem hiding this comment.
Ah, good. I feared you might have changed the JSON strings to use ;, which would be ugly! I prefer this way round.
(I suppose another option would be to use an actual JSON list, but I assume that's 10 lines of cmakery instead of just 1?)
Collaborator
Author
|
I did consider using an actual list in the JSON, but yes, it would be even more CMake scripting to find (and then correctly decrement) the length of the list, and leaving it comma separated is still just as readable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libraries_supported property is a comma separated list, but CMake uses semi-colons to understand lists. Replacing the character will allow CMake to check which libraries are set within.