✨ [client] Add ways to get HTTP clients (#130)

<!--
Copyright (C) 2020-2022 Arm Limited or its affiliates and Contributors.
All rights reserved.
SPDX-License-Identifier: Proprietary
-->
### Description

- Added utilities to help creating clients


### Test Coverage

<!--
Please put an `x` in the correct box e.g. `[x]` to indicate the testing
coverage of this change.
-->

- [x]  This change is covered by existing or additional automated tests.
- [ ] Manual testing has been performed (and evidence provided) as
automated testing was not feasible.
- [ ] Additional tests are not required for this change (e.g.
documentation update).

Author: acabarbaye

changes/20251027104429.feature

@@ -0,0 +1 @@
+:sparkles: [client] Add ways to get HTTP clients

utils/client/client.go

@@ -12,12 +12,25 @@ import (
 
 	_client "github.com/ARM-software/embedded-development-services-client/client"
 	"github.com/ARM-software/golang-utils/utils/commonerrors"
+	"github.com/ARM-software/golang-utils/utils/field"
 	"github.com/ARM-software/golang-utils/utils/http"
 	"github.com/ARM-software/golang-utils/utils/reflection"
 )
 
 // NewClient returns a new API client based on request configuration
 func NewClient(cfg *http.RequestConfiguration, logger logr.Logger, underlyingHTTPClient *_http.Client) (c *_client.APIClient, err error) {
+	httpClient, err := NewHTTPClient(cfg, http.DefaultBasicRetryPolicyConfiguration(), logger, underlyingHTTPClient)
+	if err != nil {
+		return
+	}
+	clientCfg := newClientConfiguration(cfg)
+	clientCfg.HTTPClient = httpClient.StandardClient()
+	c = _client.NewAPIClient(clientCfg)
+	return
+}
+
+// NewHTTPClient returns an HTTP retryable client based on request configuration
+func NewHTTPClient(cfg *http.RequestConfiguration, retryCfg *http.RetryPolicyConfiguration, logger logr.Logger, underlyingHTTPClient *_http.Client) (httpClient http.IRetryableClient, err error) {
 	if logger.IsZero() {
 		err = commonerrors.ErrNoLogger
 		return
@@ -32,11 +45,9 @@ func NewClient(cfg *http.RequestConfiguration, logger logr.Logger, underlyingHTT
 		return
 	}
 
-	httpClientCfg := http.DefaultRobustHTTPClientConfiguration()
-	httpClient := http.NewConfigurableRetryableClientWithLoggerAndCustomClient(httpClientCfg, cfg, logger, underlyingHTTPClient)
-	clientCfg := newClientConfiguration(cfg)
-	clientCfg.HTTPClient = httpClient.StandardClient()
-	c = _client.NewAPIClient(clientCfg)
+	httpClientCfg := http.DefaultHTTPClientConfiguration()
+	httpClientCfg.RetryPolicy = field.Optional[http.RetryPolicyConfiguration](retryCfg, *http.DefaultBasicRetryPolicyConfiguration())
+	httpClient = http.NewConfigurableRetryableClientWithLoggerAndCustomClient(httpClientCfg, cfg, logger, underlyingHTTPClient)
 	return
 }
 

utils/go.mod

@@ -4,7 +4,7 @@ go 1.25
 
 require (
 	github.com/ARM-software/embedded-development-services-client/client v1.82.0
-	github.com/ARM-software/golang-utils/utils v1.129.0
+	github.com/ARM-software/golang-utils/utils v1.130.0
 	github.com/go-faker/faker/v4 v4.7.0
 	github.com/go-logr/logr v1.4.3
 	github.com/perimeterx/marshmallow v1.1.5
@@ -17,7 +17,7 @@ require (
 
 require (
 	al.essio.dev/pkg/shellescape v1.5.1 // indirect
-	github.com/DeRuina/timberjack v1.3.8 // indirect
+	github.com/DeRuina/timberjack v1.3.9 // indirect
 	github.com/OneOfOne/xxhash v1.2.8 // indirect
 	github.com/asaskevich/govalidator v0.0.0-20200108200545-475eaeb16496 // indirect
 	github.com/avast/retry-go/v4 v4.7.0 // indirect

utils/go.sum

@@ -3,11 +3,11 @@ al.essio.dev/pkg/shellescape v1.5.1/go.mod h1:6sIqp7X2P6mThCQ7twERpZTuigpr6KbZWt
 bitbucket.org/creachadair/stringset v0.0.9/go.mod h1:t+4WcQ4+PXTa8aQdNKe40ZP6iwesoMFWAxPGd3UGjyY=
 github.com/ARM-software/embedded-development-services-client/client v1.82.0 h1:in5rwsgAlk7LYQROvU7BmSpoXCn4GA3V85W9/ODE0UM=
 github.com/ARM-software/embedded-development-services-client/client v1.82.0/go.mod h1:jGywz6vB+i3RkF6J7LXSs0l4g6xHuGfbhW+iWMEODkY=
-github.com/ARM-software/golang-utils/utils v1.129.0 h1:dUGro1vQf/T+u95sts3bAHe9oNvk9SNimld29vhnxPM=
-github.com/ARM-software/golang-utils/utils v1.129.0/go.mod h1:VmB1bgsNOJ5gF7qqKddjpEpfZKi+nkHX3LGmFoY7VFc=
+github.com/ARM-software/golang-utils/utils v1.130.0 h1:1LBLweH1qgJOxynOrcjbPeeoaiaPll8fYCa3ugLyyy4=
+github.com/ARM-software/golang-utils/utils v1.130.0/go.mod h1:l1W+4uRhZCVEoDzozfomDG6erB6kZz63Q+DCn6xNGM8=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
-github.com/DeRuina/timberjack v1.3.8 h1:lLxmRExvZygKSbb27Vp9hS0Tv8mL0WmFbwfRF29nY0Q=
-github.com/DeRuina/timberjack v1.3.8/go.mod h1:RLoeQrwrCGIEF8gO5nV5b/gMD0QIy7bzQhBUgpp1EqE=
+github.com/DeRuina/timberjack v1.3.9 h1:6UXZ1I7ExPGTX/1UNYawR58LlOJUHKBPiYC7WQ91eBo=
+github.com/DeRuina/timberjack v1.3.9/go.mod h1:RLoeQrwrCGIEF8gO5nV5b/gMD0QIy7bzQhBUgpp1EqE=
 github.com/OneOfOne/xxhash v1.2.8 h1:31czK/TI9sNkxIKfaUfGlU47BAxQ0ztGgd9vPyqimf8=
 github.com/OneOfOne/xxhash v1.2.8/go.mod h1:eZbhyaAYD41SGSSsnmcpxVoRiQ/MPUTjUdIIOT9Um7Q=
 github.com/StackExchange/wmi v1.2.0/go.mod h1:3eOhrUMpNV+6aFIbp5/iudMxNCF27Vw2OZgy4xEx0Fg=