✨ errors Improve the error that is returned when a response cannot be unmarshalled as JSON

Author: joshjennings98

changes/20250407100502.feature

@@ -0,0 +1 @@
+:sparkles: `errors` Improve the error that is returned when a response cannot be unmarshalled as JSON

utils/api/api.go

@@ -13,6 +13,7 @@ import (
 	"strings"
 
 	"github.com/ARM-software/embedded-development-services-client-utils/utils/errors"
+	"github.com/ARM-software/golang-utils/utils/commonerrors"
 	"github.com/ARM-software/golang-utils/utils/parallelisation"
 	"github.com/ARM-software/golang-utils/utils/reflection"
 )
@@ -40,7 +41,7 @@ func CheckAPICallSuccess(ctx context.Context, errorContext string, resp *_http.R
 		if resp != nil {
 			statusCode = resp.StatusCode
 			errorDetails, subErr := errors.FetchAPIErrorDescriptionWithContext(ctx, resp)
-			if subErr != nil {
+			if commonerrors.Ignore(subErr, commonerrors.ErrMarshalling) != nil {
 				err = subErr
 				return
 			}

utils/errors/errors.go

@@ -14,6 +14,7 @@ import (
 	"strings"
 
 	"github.com/ARM-software/embedded-development-services-client/client"
+	"github.com/ARM-software/golang-utils/utils/commonerrors"
 	"github.com/ARM-software/golang-utils/utils/parallelisation"
 	"github.com/ARM-software/golang-utils/utils/reflection"
 	"github.com/ARM-software/golang-utils/utils/safeio"
@@ -51,6 +52,7 @@ func FetchAPIErrorDescriptionWithContext(ctx context.Context, resp *_http.Respon
 	}
 	if err != nil {
 		message = string(bytes)
+		err = commonerrors.WrapError(commonerrors.ErrMarshalling, err, "error occurred when unmarshalling response")
 		return
 	}
 	apiErrorMessage := strings.Builder{}