Skip to content

Commit b79448a

Browse files
authored
🐛 [artefacts] fix function signature (#85)
<!-- Copyright (C) 2020-2022 Arm Limited or its affiliates and Contributors. All rights reserved. SPDX-License-Identifier: Proprietary --> ### Description <!-- Please add any detail or context that would be useful to a reviewer. --> ### Test Coverage <!-- Please put an `x` in the correct box e.g. `[x]` to indicate the testing coverage of this change. --> - [ ] This change is covered by existing or additional automated tests. - [ ] Manual testing has been performed (and evidence provided) as automated testing was not feasible. - [x] Additional tests are not required for this change (e.g. documentation update).
1 parent fab73be commit b79448a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

changes/20241030153615.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
:bug: `[artefacts]` fix function signature

utils/artefacts/artefacts.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ type (
2828
// GetArtefactManagersFirstPageFunc defines the function which can retrieve the first page of artefact managers.
2929
GetArtefactManagersFirstPageFunc = func(ctx context.Context, job string) (*client.ArtefactManagerCollection, *http.Response, error)
3030
// FollowLinkToArtefactManagersPageFunc is a function able to follow a link to an artefact manager page.
31-
FollowLinkToArtefactManagersPageFunc = func(ctx context.Context, href string) (*client.ArtefactManagerCollection, *http.Response, error)
31+
FollowLinkToArtefactManagersPageFunc = func(ctx context.Context, link *client.HalLinkData) (*client.ArtefactManagerCollection, *http.Response, error)
3232
// GetArtefactManagerFunc is a function which retrieves information about an artefact manager.
3333
GetArtefactManagerFunc = func(ctx context.Context, job, artefact string) (*client.ArtefactManagerItem, *http.Response, error)
3434
// GetArtefactContentFunc is a function able to return the content of any artefact managers.
@@ -247,7 +247,7 @@ func (m *ArtefactManager) fetchJobArtefactsNextPage(ctx context.Context, current
247247
return
248248
}
249249
link := links.GetNext()
250-
clientPage, resp, apierr := m.getArtefactManagersFollowLinkFunc(ctx, link.GetHref())
250+
clientPage, resp, apierr := m.getArtefactManagersFollowLinkFunc(ctx, &link)
251251
if resp != nil {
252252
_ = resp.Body.Close()
253253
}

0 commit comments

Comments
 (0)