⚙️ lint (#127)

<!--
Copyright (C) 2020-2022 Arm Limited or its affiliates and Contributors.
All rights reserved.
SPDX-License-Identifier: Proprietary
-->
### Description

Upgrade the linting

### Test Coverage

<!--
Please put an `x` in the correct box e.g. `[x]` to indicate the testing
coverage of this change.
-->

- [x]  This change is covered by existing or additional automated tests.
- [ ] Manual testing has been performed (and evidence provided) as
automated testing was not feasible.
- [ ] Additional tests are not required for this change (e.g.
documentation update).

Author: acabarbaye

.github/workflows/build-and-test.yml

@@ -71,12 +71,12 @@ jobs:
         working-directory: ${{ matrix.go-module }}
       - if: ${{ startsWith(matrix.os, 'ubuntu') }}
         name: Linting
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v8
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version.
           version: latest
           working-directory: ${{ matrix.go-module }}
-          args: "--verbose --print-issued-lines --print-linter-name --out-${NO_FUTURE}format colored-line-number --timeout 300s --max-issues-per-linter 0 --max-same-issues 0"
+          args: "--verbose --output.text.print-issued-lines --output.text.print-linter-name --output.tab.colors --max-issues-per-linter 0 --max-same-issues 0"
       - name: Test ${{ matrix.go-module }} on ${{ matrix.os }}
         run: go test -race -cover -v ./...
-        working-directory: ${{ matrix.go-module }}
+        working-directory: ${{ matrix.go-module }}

.golangci.yaml

@@ -1,51 +1,65 @@
+version: "2"
 run:
-  timeout: 10m
-
-  # Run linters over integration tests
   build-tags:
     - integration
-
 linters:
-  disable-all: true # Disable defaults, then enable the ones we want
+  default: none
   enable:
+    - bodyclose
     - errcheck
-    - gosimple
+    - gocritic
+    - gosec
     - govet
     - ineffassign
+    - misspell
+    - revive
     - staticcheck
-    - typecheck
+    - unconvert
     - unused
-    - bodyclose
-    - stylecheck
-    - gosec
-    - goimports
+  settings:
+    misspell:
+      locale: UK
+      extra-words:
+        - typo: sanetisation
+          correction: sanitisation
+        - typo: sanetise
+          correction: sanitise
+        - typo: sanetising
+          correction: sanitising
+    revive:
+      rules:
+        - name: exported
+          arguments:
+            - disableStutteringCheck
+          severity: warning
+          disabled: false
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
     - gci
-    - revive
-    - gocritic
-    - unconvert
-    - misspell
-
-linters-settings:
-  goimports:
-    local-prefixes: github.com/ARM-software
-  gci:
-    sections:
-      - Standard
-      - Default
-      - Prefix(github.com/ARM-software)
-  revive:
-    rules:
-      - name: exported
-        severity: warning
-        disabled: false
-        arguments:
-          - "disableStutteringCheck"
-  misspell:
-    locale: UK
-    extra-words:
-      - typo: "sanetisation"
-        correction: "sanitisation"
-      - typo: "sanetise"
-        correction: "sanitise"
-      - typo: "sanetising"
-        correction: "sanitising"
+    - goimports
+  settings:
+    gci:
+      sections:
+        - Standard
+        - Default
+        - Prefix(github.com/ARM-software)
+    goimports:
+      local-prefixes:
+        - github.com/ARM-software
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

changes/202510241630.misc

@@ -0,0 +1 @@
+:builder: Upgrade the linting

utils/client/client.go

@@ -42,8 +42,8 @@ func NewClient(cfg *http.RequestConfiguration, logger logr.Logger, underlyingHTT
 
 func newClientConfiguration(cfg *http.RequestConfiguration) (clientCfg *_client.Configuration) {
 	clientCfg = _client.NewConfiguration()
-	if !reflection.IsEmpty(cfg.Target.Host) {
-		basePathURL, err := url.Parse(cfg.Target.Host)
+	if !reflection.IsEmpty(cfg.Host) {
+		basePathURL, err := url.Parse(cfg.Host)
 		if err == nil {
 			clientCfg.Host = basePathURL.Host
 			clientCfg.Scheme = basePathURL.Scheme

utils/job/manager_test.go

@@ -199,7 +199,7 @@ func TestManager_BrowseMessages(t *testing.T) {
 				assert.NotNil(t, messagePaginator)
 				count := 0
 				for {
-					if !messagePaginator.HasNext() {
+					if !messagePaginator.HasNext() { //nolint:staticcheck
 						break
 					}
 					message, subErr := messagePaginator.GetNext()

utils/messages/testing_test.go

@@ -25,7 +25,7 @@ func Test_NewMockNotificationFeedPage(t *testing.T) {
 		it, err := page.GetItemIterator()
 		require.NoError(t, err)
 		for {
-			if !it.HasNext() {
+			if !it.HasNext() { //nolint:staticcheck
 				break
 			}
 			next, err := it.GetNext()

utils/pagination/page_test.go

@@ -105,7 +105,7 @@ func TestToPage(t *testing.T) {
 				itback, err := mappedBack.GetItemIterator()
 				require.NoError(t, err)
 				for {
-					if !it.HasNext() {
+					if !it.HasNext() { //nolint:staticcheck
 						break
 					}
 					assert.True(t, itback.HasNext())

utils/pagination/stream_test.go

@@ -101,7 +101,7 @@ func TestToStream(t *testing.T) {
 				itBack, err := mappedBack.GetItemIterator()
 				require.NoError(t, err)
 				for {
-					if !it.HasNext() {
+					if !it.HasNext() { //nolint:staticcheck
 						break
 					}
 					assert.True(t, itBack.HasNext())