fix(pcie): handle NOT_IMPLEMENTED return from pal_get_msi_vectors

- Skip the test when pal_get_msi_vectors() is not implemented.
- Preserve original behavior for zero and non-zero return values.

Signed-off-by: Sahil Shakil Malpekar <Sahil.ShakilMalpekar@arm.com>
Change-Id: Iea213a90eb8b359c9becc1cd0bcdbdf66109a40e

Author: Sahil-Malpekar

test_pool/pcie/p046.c

@@ -84,6 +84,7 @@ payload (void)
   PERIPHERAL_VECTOR_LIST *dev_mvec, *mvec;
   uint64_t dev_bdf;
   uint32_t test_skip = 1;
+  uint32_t ret;
 
   if(!count) {
      val_set_status (index, RESULT_SKIP (TEST_NUM, 2));
@@ -104,11 +105,15 @@ payload (void)
       if (dev_bdf) {
         val_print (ACS_PRINT_INFO, "       Checking PCI device with BDF %4X\n", dev_bdf);
         /* Read MSI(X) vectors */
-        if (val_get_msi_vectors(dev_bdf, &dev_mvec) == NOT_IMPLEMENTED) {
+        ret = val_get_msi_vectors (dev_bdf, &dev_mvec);
+
+        if (ret == NOT_IMPLEMENTED) {
           val_print(ACS_PRINT_ERR,
-            "\n       pal_get_msi_vectors is unimplemented, Skipping test.", 0);
+              "\n       pal_get_msi_vectors is unimplemented, Skipping test.", 0);
           goto test_skip_unimplemented;
-        } else {
+        }
+
+        if (ret) {
           test_skip = 0;
           mvec = dev_mvec;
           while(mvec) {

test_pool/pcie/p097.c

@@ -128,6 +128,7 @@ payload (void)
   uint32_t bdf, dp_type;
   uint32_t class_code;
   uint32_t base_cc;
+  uint32_t ret;
   status = 0;
 
   bdf_tbl_ptr = val_pcie_bdf_table_ptr();
@@ -166,11 +167,15 @@ payload (void)
           continue;
         }
 
-        if (val_get_msi_vectors(current_dev_bdf, &current_dev_mvec) == NOT_IMPLEMENTED) {
+        ret = val_get_msi_vectors (current_dev_bdf, &current_dev_mvec);
+
+        if (ret == NOT_IMPLEMENTED) {
           val_print(ACS_PRINT_ERR,
-            "\n       pal_get_msi_vectors is unimplemented, Skipping test.", 0);
+              "\n       pal_get_msi_vectors is unimplemented, Skipping test.", 0);
           goto test_skip_unimplemented;
-        } else {
+        }
+
+        if (ret) {
             tbl_index_next = tbl_index + 1;
             while (tbl_index_next < bdf_tbl_ptr->num_entries && !status)
             {
@@ -209,11 +214,15 @@ payload (void)
                   }
 
                   /* Read MSI(X) vectors */
-                  if (val_get_msi_vectors(next_dev_bdf, &next_dev_mvec) == NOT_IMPLEMENTED) {
+                  ret = val_get_msi_vectors (next_dev_bdf, &next_dev_mvec);
+
+                  if (ret == NOT_IMPLEMENTED) {
                     val_print(ACS_PRINT_ERR,
-                      "\n       pal_get_msi_vectors is unimplemented, Skipping test.", 0);
+                        "\n       pal_get_msi_vectors is unimplemented, Skipping test.", 0);
                     goto test_skip_unimplemented;
-                  } else {
+                  }
+
+                  if (ret) {
                     test_skip = 0;
                     /* Compare two lists of MSI(X) vectors */
                     if (check_list_duplicates (current_dev_mvec, next_dev_mvec))

test_pool/peripherals/d004.c

@@ -182,7 +182,7 @@ payload_check_io_coherent_dma_mem_attribute(void)
     return;
 
 test_skip_unimplemented:
-    val_set_status(index, RESULT_SKIP(TEST_NUM, 2));
+    val_set_status(index, RESULT_SKIP(TEST_NUM1, 2));
 }
 
 uint32_t