Skip to content

Commit 020685c

Browse files
author
Offir Kochalsky
committed
Added error logging at set QPI
1 parent 9b3bca8 commit 020685c

File tree

1 file changed

+24
-13
lines changed

1 file changed

+24
-13
lines changed

components/storage/blockdevice/COMPONENT_QSPIF/QSPIFBlockDevice.cpp

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -781,33 +781,44 @@ int QSPIFBlockDevice::_sfdp_set_qpi_enabled(uint8_t *basic_param_table_ptr)
781781
switch (en_seq_444_value) {
782782
case 1:
783783
case 2:
784-
tr_debug("_setQPIEnabled - send command 38h");
785-
_qspi_send_general_command(0x38, QSPI_NO_ADDRESS_COMMAND, NULL, 0, NULL, 0);
784+
tr_debug("_sfdp_set_qpi_enabled - send command 38h");
785+
if (QSPI_STATUS_OK != _qspi_send_general_command(0x38, QSPI_NO_ADDRESS_COMMAND, NULL, 0, NULL, 0)) {
786+
tr_error("_sfdp_set_qpi_enabled - send command 38h Failed");
787+
}
786788
break;
787789

788790
case 4:
789-
tr_debug("_setQPIEnabled - send command 35h");
790-
_qspi_send_general_command(0x35, QSPI_NO_ADDRESS_COMMAND, NULL, 0, NULL, 0);
791+
tr_debug("_sfdp_set_qpi_enabled - send command 35h");
792+
if (QSPI_STATUS_OK != _qspi_send_general_command(0x35, QSPI_NO_ADDRESS_COMMAND, NULL, 0, NULL, 0)) {
793+
tr_error("_sfdp_set_qpi_enabled - send command 35h Failed");
794+
}
791795
break;
792796

793797
case 8:
794-
tr_debug("_setQPIEnabled - set config bit 6 and send command 71h");
795-
_qspi_send_general_command(0x65, 0x800003, NULL, 0, (char *)config_reg, 1);
798+
tr_debug("_sfdp_set_qpi_enabled - set config bit 6 and send command 71h");
799+
if (QSPI_STATUS_OK != _qspi_send_general_command(0x65, 0x800003, NULL, 0, (char *)config_reg, 1)) {
800+
tr_error("_sfdp_set_qpi_enabled - set config bit 6 command 65h Failed");
801+
}
796802
config_reg[0] |= 0x40; //Set Bit 6
797-
_qspi_send_general_command(0x71, 0x800003, NULL, 0, (char *)config_reg, 1);
803+
if (QSPI_STATUS_OK != _qspi_send_general_command(0x71, 0x800003, NULL, 0, (char *)config_reg, 1)) {
804+
tr_error("_sfdp_set_qpi_enabled - send command 71h Failed");
805+
}
798806
break;
799807

800808
case 16:
801-
tr_debug("DEBUG: _setQPIEnabled - reset config bits 0-7 and send command 61h");
802-
_qspi_send_general_command(0x65, QSPI_NO_ADDRESS_COMMAND, NULL, 0, (char *)config_reg, 1);
809+
tr_debug("_sfdp_set_qpi_enabled - reset config bits 0-7 and send command 61h");
810+
if (QSPI_STATUS_OK != _qspi_send_general_command(0x65, QSPI_NO_ADDRESS_COMMAND, NULL, 0, (char *)config_reg, 1)) {
811+
tr_error("_sfdp_set_qpi_enabled - send command 65h Failed");
812+
}
803813
config_reg[0] &= 0x7F; //Reset Bit 7 of CR
804-
_qspi_send_general_command(0x61, QSPI_NO_ADDRESS_COMMAND, NULL, 0, (char *)config_reg, 1);
814+
if (QSPI_STATUS_OK != _qspi_send_general_command(0x61, QSPI_NO_ADDRESS_COMMAND, NULL, 0, (char *)config_reg, 1)) {
815+
tr_error("_sfdp_set_qpi_enabled - send command 61 Failed");
816+
}
805817
break;
806818

807819
default:
808-
tr_warning("_setQPIEnabled - Unsuported En Seq 444 configuration");
820+
tr_warning("_sfdp_set_qpi_enabled - Unsuported En Seq 444 configuration");
809821
break;
810-
811822
}
812823
return 0;
813824
}
@@ -1087,7 +1098,7 @@ int QSPIFBlockDevice::_reset_flash_mem()
10871098
QSPI_MAX_STATUS_REGISTER_SIZE) ) { // store received values in status_value
10881099
tr_debug("Reading Status Register Success: value = 0x%x", (int)status_value[0]);
10891100
} else {
1090-
tr_debug("Reading Status Register failed: value = 0x%x", (int)status_value[0]);
1101+
tr_error("Reading Status Register failed: value = 0x%x", (int)status_value[0]);
10911102
status = -1;
10921103
}
10931104

0 commit comments

Comments
 (0)