Unittests fixed + readme updated

- Unittests were broken and are now fixed
- README.md is updated to have small instructiopn how to run unittests

Author: Antti Kauppila

features/cellular/README.md

@@ -62,3 +62,15 @@ Debug tracing level can be defined in mbed_app.json configuration file:
             "value": "TRACE_LEVEL_INFO"
         }
     }
+
+## Unit tests
+
+UNITTESTS folder contains unittests for Cellular specific classes. Unittests are based on stubbing method and some of the platform headers has been hacked under target_h/ folder to get things working.
+
+You can run those tests locally by running ./run_tests script under UNITTESTS/ folder.
+
+you will need at least following applications: cpputest, gcov and lcov (genhtml) for running the tests.
+After run_tests script has been run you can find test results under UNITTESTS/results folder and line & function coverages under UNITTESTS/coverages folder
+
+
+

features/cellular/UNITTESTS/at/at_cellularbase/test_at_cellularbase.cpp

@@ -38,7 +38,7 @@ void Test_AT_CellularBase::test_AT_CellularBase_get_at_handler()
 {
     EventQueue eq;
     FileHandle_stub fh;
-    ATHandler ah(&fh, eq, 100);
+    ATHandler ah(&fh, eq, 100, ",");
     AT_CellularBase at(ah);
 
     CHECK(&ah == &at.get_at_handler());
@@ -48,7 +48,7 @@ void Test_AT_CellularBase::test_AT_CellularBase_get_device_error()
 {
     EventQueue eq;
     FileHandle_stub fh;
-    ATHandler ah(&fh, eq, 0);
+    ATHandler ah(&fh, eq, 0, ",");
     AT_CellularBase at(ah);
 
     ATHandler_stub::device_err_value.errCode = 8;

features/cellular/UNITTESTS/at/at_cellulardevice/test_at_cellulardevice.cpp

@@ -159,7 +159,7 @@ void Test_AT_CellularDevice::test_AT_CellularDevice_close_information()
     dev.close_information();
 
     ATHandler_stub::fh_value = &fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
     AT_CellularBase_stub::handler_value = &at;
 
     CHECK(dev.open_information(&fh1));

features/cellular/UNITTESTS/at/at_cellularinformation/test_at_cellularinformation.cpp

@@ -40,7 +40,7 @@ void Test_AT_CellularInformation::test_AT_CellularInformation_get_manufacturer()
 {
     EventQueue eq;
     FileHandle_stub fh;
-    ATHandler ah(&fh, eq, 0);
+    ATHandler ah(&fh, eq, 0, ",");
     AT_CellularInformation aci(ah);
 
     ATHandler_stub::nsapi_error_value = 8;
@@ -53,7 +53,7 @@ void Test_AT_CellularInformation::test_AT_CellularInformation_get_model()
 {
     EventQueue eq;
     FileHandle_stub fh;
-    ATHandler ah(&fh, eq, 0);
+    ATHandler ah(&fh, eq, 0, ",");
     AT_CellularInformation aci(ah);
 
     ATHandler_stub::nsapi_error_value = 7;
@@ -66,7 +66,7 @@ void Test_AT_CellularInformation::test_AT_CellularInformation_get_revision()
 {
     EventQueue eq;
     FileHandle_stub fh;
-    ATHandler ah(&fh, eq, 0);
+    ATHandler ah(&fh, eq, 0, ",");
 
     //Used heap var here to visit heap constructor
     AT_CellularInformation *aci = new AT_CellularInformation(ah);

features/cellular/UNITTESTS/at/at_cellularmultiplexer/test_at_cellularmultiplexer.cpp

@@ -39,7 +39,7 @@ void Test_AT_CellularMultiplexer::test_AT_CellularMultiplexer_constructor()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularMultiplexer *cm = new AT_CellularMultiplexer(at);
     delete cm;
@@ -49,7 +49,7 @@ void Test_AT_CellularMultiplexer::test_AT_CellularMultiplexer_multiplexer_mode_s
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularMultiplexer cm(at);
     CHECK(!cm.multiplexer_mode_start());

features/cellular/UNITTESTS/at/at_cellularnetwork/at_cellularnetworktest.cpp

@@ -92,11 +92,6 @@ TEST(AT_CellularNetwork, test_AT_CellularNetwork_get_backoff_time)
     unit->test_AT_CellularNetwork_get_backoff_time();
 }
 
-TEST(AT_CellularNetwork, test_AT_CellularNetwork_connection_status_cb)
-{
-    unit->test_AT_CellularNetwork_connection_status_cb();
-}
-
 TEST(AT_CellularNetwork, test_AT_CellularNetwork_get_ip_address)
 {
     unit->test_AT_CellularNetwork_get_ip_address();

features/cellular/UNITTESTS/at/at_cellularnetwork/test_at_cellularnetwork.cpp

@@ -28,6 +28,13 @@
 using namespace mbed;
 using namespace events;
 
+class my_AT_CN : public AT_CellularNetwork {
+public:
+    my_AT_CN(ATHandler &atHandler) : AT_CellularNetwork(atHandler) {}
+    virtual ~my_AT_CN() {}
+    NetworkStack *get_stack() {return AT_CellularNetwork::get_stack();}
+};
+
 void conn_stat_cb(nsapi_error_t error)
 {
 
@@ -47,7 +54,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_constructor()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork *cn = new AT_CellularNetwork(at);
 
@@ -58,7 +65,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_set_credentials()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CHECK(NSAPI_ERROR_OK == cn.set_credentials("apn", CellularNetwork::CHAP));
@@ -70,7 +77,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_connect()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     cn.set_stack_type(IPV4V6_STACK);
@@ -84,7 +91,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_disconnect()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CHECK(NSAPI_ERROR_OK == cn.disconnect());
@@ -94,17 +101,17 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_stack()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
-    AT_CellularNetwork cn(at);
+    my_AT_CN cn(at);
     CHECK(!cn.get_stack());
 }
 
 void Test_AT_CellularNetwork::test_AT_CellularNetwork_set_registration()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     ATHandler_stub::nsapi_error_value = NSAPI_ERROR_CONNECTION_LOST;
@@ -115,7 +122,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_registration_status()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CellularNetwork::RegistrationStatus stat;
@@ -126,7 +133,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_set_attach()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     ATHandler_stub::nsapi_error_value = NSAPI_ERROR_CONNECTION_LOST;
@@ -137,7 +144,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_attach()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CellularNetwork::AttachStatus stat;
@@ -149,7 +156,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_rate_control()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int ur;
@@ -162,33 +169,20 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_backoff_time()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int time;
     ATHandler_stub::nsapi_error_value = NSAPI_ERROR_CONNECTION_LOST;
     CHECK(NSAPI_ERROR_CONNECTION_LOST == cn.get_backoff_time(time));
 }
 
-void Test_AT_CellularNetwork::test_AT_CellularNetwork_connection_status_cb()
-{
-    EventQueue que;
-    FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
-
-    AT_CellularNetwork cn(at);
-    cn.connection_status_cb(conn_stat_cb);
-
-    if(ATHandler_stub::callback){
-        ATHandler_stub::callback();
-    }
-}
 
 void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_ip_address()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CHECK(!cn.get_ip_address());
@@ -198,7 +192,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_set_access_technology()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CHECK(NSAPI_ERROR_UNSUPPORTED == cn.set_access_technology(CellularNetwork::operator_t::RAT_UNKNOWN));
@@ -209,7 +203,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_scan_plmn()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int c;
@@ -222,7 +216,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_set_ciot_optimization_conf
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     ATHandler_stub::nsapi_error_value = NSAPI_ERROR_CONNECTION_LOST;
@@ -233,7 +227,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_ciot_optimization_conf
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CellularNetwork::Supported_UE_Opt sup;
@@ -246,7 +240,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_set_stack_type()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CHECK(NSAPI_ERROR_PARAMETER == cn.set_stack_type(IPV4_STACK));
@@ -258,7 +252,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_stack_type()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CHECK(DEFAULT_STACK == cn.get_stack_type());
@@ -268,7 +262,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_pdpcontext_params()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     CellularNetwork::pdpContextList_t list;
@@ -280,7 +274,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_extended_signal_qualit
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int rx,be,rs,ec,rsrq,rsrp;
@@ -294,7 +288,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_signal_quality()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int rs,ber;
@@ -308,7 +302,7 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_cell_id()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int id;
@@ -320,18 +314,18 @@ void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_3gpp_error()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
-    ATHandler_stub::uint8_value = 8;
+    ATHandler_stub::int_value = 8;
     CHECK(8 == cn.get_3gpp_error());
 }
 
 void Test_AT_CellularNetwork::test_AT_CellularNetwork_get_operator_params()
 {
     EventQueue que;
     FileHandle_stub fh1;
-    ATHandler at(&fh1, que, 0);
+    ATHandler at(&fh1, que, 0, ",");
 
     AT_CellularNetwork cn(at);
     int format;

features/cellular/UNITTESTS/at/at_cellularnetwork/test_at_cellularnetwork.h

@@ -46,8 +46,6 @@ class Test_AT_CellularNetwork
 
     void test_AT_CellularNetwork_get_backoff_time();
 
-    void test_AT_CellularNetwork_connection_status_cb();
-
     void test_AT_CellularNetwork_get_ip_address();
 
     void test_AT_CellularNetwork_set_access_technology();