Merge pull request #14423 from mczerski/stm32_faster_analog_out

0xc0170 · web-flow · commit 09eac13ffbb1 · 2021-03-12T13:14:13.000Z
STM32: AnalogOut: do not call HAL_DAC_Start in dac_write
diff --git a/targets/TARGET_STM/TARGET_STM32F0/analogout_device.c b/targets/TARGET_STM/TARGET_STM32F0/analogout_device.c
@@ -74,6 +74,7 @@ void analogout_init(dac_t *obj, PinName pin)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_free(dac_t *obj)
diff --git a/targets/TARGET_STM/TARGET_STM32F1/analogout_device.c b/targets/TARGET_STM/TARGET_STM32F1/analogout_device.c
@@ -86,6 +86,7 @@ void analogout_init(dac_t *obj, PinName pin)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_free(dac_t *obj)
diff --git a/targets/TARGET_STM/TARGET_STM32F2/analogout_device.c b/targets/TARGET_STM/TARGET_STM32F2/analogout_device.c
@@ -86,6 +86,7 @@ void analogout_init(dac_t *obj, PinName pin)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_free(dac_t *obj)
diff --git a/targets/TARGET_STM/TARGET_STM32F3/analogout_device.c b/targets/TARGET_STM/TARGET_STM32F3/analogout_device.c
@@ -121,6 +121,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/TARGET_STM32F4/analogout_device.c b/targets/TARGET_STM/TARGET_STM32F4/analogout_device.c
@@ -81,6 +81,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/TARGET_STM32F7/analogout_device.c b/targets/TARGET_STM/TARGET_STM32F7/analogout_device.c
@@ -86,6 +86,7 @@ void analogout_init(dac_t *obj, PinName pin)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_free(dac_t *obj)
diff --git a/targets/TARGET_STM/TARGET_STM32G0/analogout_device.c b/targets/TARGET_STM/TARGET_STM32G0/analogout_device.c
@@ -90,6 +90,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/TARGET_STM32G4/analogout_device.c b/targets/TARGET_STM/TARGET_STM32G4/analogout_device.c
@@ -109,6 +109,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/TARGET_STM32H7/analogout_device.c b/targets/TARGET_STM/TARGET_STM32H7/analogout_device.c
@@ -74,6 +74,7 @@ void analogout_init(dac_t *obj, PinName pin)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_free(dac_t *obj)
diff --git a/targets/TARGET_STM/TARGET_STM32L0/analogout_device.c b/targets/TARGET_STM/TARGET_STM32L0/analogout_device.c
@@ -90,6 +90,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/TARGET_STM32L1/analogout_device.c b/targets/TARGET_STM/TARGET_STM32L1/analogout_device.c
@@ -81,6 +81,7 @@ void analogout_init(dac_t *obj, PinName pin)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_free(dac_t *obj)
diff --git a/targets/TARGET_STM/TARGET_STM32L4/analogout_device.c b/targets/TARGET_STM/TARGET_STM32L4/analogout_device.c
@@ -97,6 +97,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 
     /* DAC cannot be used in deepsleep/STOP mode */
     sleep_manager_lock_deep_sleep();
diff --git a/targets/TARGET_STM/TARGET_STM32L5/analogout_device.c b/targets/TARGET_STM/TARGET_STM32L5/analogout_device.c
@@ -94,6 +94,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/TARGET_STM32WL/analogout_device.c b/targets/TARGET_STM/TARGET_STM32WL/analogout_device.c
@@ -80,6 +80,7 @@ static void _analogout_init_direct(dac_t *obj, const PinMap *pinmap)
     }
 
     analogout_write_u16(obj, 0);
+    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 void analogout_init(dac_t *obj, PinName pin)
diff --git a/targets/TARGET_STM/analogout_api.c b/targets/TARGET_STM/analogout_api.c
@@ -41,7 +41,6 @@
 static inline void dac_write(dac_t *obj, int value)
 {
     HAL_DAC_SetValue(&obj->handle, obj->channel, DAC_ALIGN_12B_R, (value & DAC_RANGE));
-    HAL_DAC_Start(&obj->handle, obj->channel);
 }
 
 static inline int dac_read(dac_t *obj)

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ void analogout_init(dac_t *obj, PinName pin)`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`analogout_write_u16(obj, 0);`
	`77`	`+ HAL_DAC_Start(&obj->handle, obj->channel);`
`77`	`78`	`}`
`78`	`79`
`79`	`80`	`void analogout_free(dac_t *obj)`
Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ void analogout_init(dac_t *obj, PinName pin)`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`analogout_write_u16(obj, 0);`
	`89`	`+ HAL_DAC_Start(&obj->handle, obj->channel);`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`void analogout_free(dac_t *obj)`
Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,7 @@ static void _analogout_init_direct(dac_t obj, const PinMap pinmap)`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`analogout_write_u16(obj, 0);`
	`124`	`+ HAL_DAC_Start(&obj->handle, obj->channel);`
`124`	`125`	`}`
`125`	`126`
`126`	`127`	`void analogout_init(dac_t *obj, PinName pin)`
Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ static void _analogout_init_direct(dac_t obj, const PinMap pinmap)`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`analogout_write_u16(obj, 0);`
	`84`	`+ HAL_DAC_Start(&obj->handle, obj->channel);`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`void analogout_init(dac_t *obj, PinName pin)`
Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ static void _analogout_init_direct(dac_t obj, const PinMap pinmap)`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`analogout_write_u16(obj, 0);`
	`93`	`+ HAL_DAC_Start(&obj->handle, obj->channel);`
`93`	`94`	`}`
`94`	`95`
`95`	`96`	`void analogout_init(dac_t *obj, PinName pin)`
Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ static void _analogout_init_direct(dac_t obj, const PinMap pinmap)`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`analogout_write_u16(obj, 0);`
	`112`	`+ HAL_DAC_Start(&obj->handle, obj->channel);`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`void analogout_init(dac_t *obj, PinName pin)`