event handler should not affect internal state

paul-szczepanek-arm · pan- · commit 0a3cd69fc66c · 2020-10-05T11:53:22.000+01:00
diff --git a/connectivity/FEATURE_BLE/source/generic/GapImpl.cpp b/connectivity/FEATURE_BLE/source/generic/GapImpl.cpp
@@ -2333,13 +2333,14 @@ void Gap::on_enhanced_connection_complete(
     clock_accuracy_t master_clock_accuracy
 )
 {
+    if (own_role == connection_role_t::CENTRAL) {
+        _initiating = false;
+    }
+
     if (!_event_handler) {
         return;
     }
 
-    if (own_role == connection_role_t::CENTRAL) {
-        _initiating = false;
-    }
 
     _event_handler->onConnectionComplete(
         ConnectionCompleteEvent(

Original file line number	Diff line number	Diff line change
`@@ -2333,13 +2333,14 @@ void Gap::on_enhanced_connection_complete(`
`2333`	`2333`	`clock_accuracy_t master_clock_accuracy`
`2334`	`2334`	`)`
`2335`	`2335`	`{`
	`2336`	`+ if (own_role == connection_role_t::CENTRAL) {`
	`2337`	`+ _initiating = false;`
	`2338`	`+ }`
	`2339`	`+`
`2336`	`2340`	`if (!_event_handler) {`
`2337`	`2341`	`return;`
`2338`	`2342`	`}`
`2339`	`2343`
`2340`		`- if (own_role == connection_role_t::CENTRAL) {`
`2341`		`- _initiating = false;`
`2342`		`- }`
`2343`	`2344`
`2344`	`2345`	`_event_handler->onConnectionComplete(`
`2345`	`2346`	`ConnectionCompleteEvent(`