Skip to content

Commit 0be41f0

Browse files
author
Hasnain Virk
committed
Remove useless extraction
Channel plan datastructure already contains channel parameters. Extraction is not needed.
1 parent bec61ce commit 0be41f0

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

features/lorawan/lorastack/mac/LoRaMacChannelPlan.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ void LoRaMacChannelPlan::activate_channelplan_subsystem(LoRaPHY *phy)
4040

4141
lorawan_status_t LoRaMacChannelPlan::set_plan(const lorawan_channelplan_t& plan)
4242
{
43-
channel_params_t mac_layer_ch_params;
4443
lorawan_status_t status;
4544

4645
uint8_t max_num_channels;
@@ -57,16 +56,7 @@ lorawan_status_t LoRaMacChannelPlan::set_plan(const lorawan_channelplan_t& plan)
5756
}
5857

5958
for (uint8_t i = 0; i < plan.nb_channels; i++) {
60-
61-
mac_layer_ch_params.band = plan.channels[i].ch_param.band;
62-
63-
mac_layer_ch_params.dr_range.fields.max = plan.channels[i].ch_param.dr_range.fields.max;
64-
mac_layer_ch_params.dr_range.fields.min = plan.channels[i].ch_param.dr_range.fields.min;
65-
mac_layer_ch_params.dr_range.value = plan.channels[i].ch_param.dr_range.value;
66-
mac_layer_ch_params.frequency = plan.channels[i].ch_param.frequency;
67-
mac_layer_ch_params.rx1_frequency = plan.channels[i].ch_param.rx1_frequency;
68-
69-
status = _lora_phy->add_channel(&mac_layer_ch_params, plan.channels[i].id);
59+
status = _lora_phy->add_channel(&plan.channels[i].ch_param, plan.channels[i].id);
7060

7161
if (status != LORAWAN_STATUS_OK) {
7262
return status;

0 commit comments

Comments
 (0)