Skip to content

Commit 0df1d49

Browse files
authored
Merge pull request #8861 from VeijoPesonen/bugfix-mbedgt_wifi_scan_one_ssid
Bugfix-tests-network-wifi drop the assumption about more than one SSID
2 parents bf36ff7 + 386915d commit 0df1d49

File tree

3 files changed

+13
-21
lines changed

3 files changed

+13
-21
lines changed

TESTS/network/wifi/main.cpp

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,32 +62,24 @@ Case cases[] = {
6262
Case("WIFI-CONNECT-NOCREDENTIALS", wifi_connect_nocredentials),
6363
Case("WIFI-SET-CREDENTIAL", wifi_set_credential),
6464
Case("WIFI-SET-CHANNEL", wifi_set_channel),
65-
#if defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
66-
Case("WIFI-GET-RSSI", wifi_get_rssi),
67-
#endif
6865
Case("WIFI-CONNECT-PARAMS-NULL", wifi_connect_params_null),
66+
Case("WIFI-SCAN-NULL", wifi_scan_null),
67+
#if defined(MBED_CONF_APP_WIFI_SECURE_SSID) || defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
68+
Case("WIFI-SCAN", wifi_scan),
69+
#endif
6970
#if defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
71+
Case("WIFI-GET-RSSI", wifi_get_rssi),
7072
Case("WIFI-CONNECT-PARAMS-VALID-UNSECURE", wifi_connect_params_valid_unsecure),
73+
Case("WIFI-CONNECT", wifi_connect),
74+
Case("WIFI-CONNECT-DISCONNECT-REPEAT", wifi_connect_disconnect_repeat),
7175
#endif
7276
#if defined(MBED_CONF_APP_WIFI_SECURE_SSID)
7377
Case("WIFI-CONNECT-PARAMS-VALID-SECURE", wifi_connect_params_valid_secure),
7478
Case("WIFI-CONNECT-PARAMS-CHANNEL", wifi_connect_params_channel),
7579
Case("WIFI-CONNECT-PARAMS-CHANNEL-FAIL", wifi_connect_params_channel_fail),
76-
#endif
77-
#if defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
78-
Case("WIFI-CONNECT", wifi_connect),
79-
#endif
80-
#if defined(MBED_CONF_APP_WIFI_SECURE_SSID)
8180
Case("WIFI-CONNECT-SECURE", wifi_connect_secure),
8281
Case("WIFI-CONNECT-SECURE-FAIL", wifi_connect_secure_fail),
8382
#endif
84-
#if defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
85-
Case("WIFI-CONNECT-DISCONNECT-REPEAT", wifi_connect_disconnect_repeat),
86-
#endif
87-
Case("WIFI-SCAN-NULL", wifi_scan_null),
88-
#if defined(MBED_CONF_APP_WIFI_SECURE_SSID) && defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
89-
Case("WIFI-SCAN", wifi_scan),
90-
#endif
9183
};
9284

9385
Specification specification(test_setup, cases, greentea_continue_handlers);

TESTS/network/wifi/wifi_scan.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,14 @@
2424

2525
using namespace utest::v1;
2626

27-
#if defined(MBED_CONF_APP_WIFI_SECURE_SSID) && defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
28-
2927
void wifi_scan(void)
3028
{
3129
WiFiInterface *wifi = get_interface();
3230

3331
WiFiAccessPoint ap[MBED_CONF_APP_MAX_SCAN_SIZE];
3432

3533
int size = wifi->scan(ap, MBED_CONF_APP_MAX_SCAN_SIZE);
36-
TEST_ASSERT(size >= 2);
34+
TEST_ASSERT(size >= 1);
3735

3836
bool secure_found = false;
3937
bool unsecure_found = false;
@@ -49,17 +47,19 @@ void wifi_scan(void)
4947
nsapi_security_t security = ap[i].get_security();
5048
int8_t rssi = ap[i].get_rssi();
5149
TEST_ASSERT_INT8_WITHIN(-10, -100, rssi);
50+
#if defined(MBED_CONF_APP_WIFI_SECURE_SSID)
5251
if (strcmp(MBED_CONF_APP_WIFI_SECURE_SSID, ssid) == 0) {
5352
secure_found = true;
5453
TEST_ASSERT_EQUAL_INT(get_security(), security);
5554
}
55+
#endif
56+
#if defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)
5657
if (strcmp(MBED_CONF_APP_WIFI_UNSECURE_SSID, ssid) == 0) {
5758
unsecure_found = true;
5859
TEST_ASSERT_EQUAL_INT(NSAPI_SECURITY_NONE, security);
5960
}
61+
#endif
6062
}
6163
// Finding one SSID is enough
6264
TEST_ASSERT_TRUE(secure_found || unsecure_found);
6365
}
64-
65-
#endif // defined(MBED_CONF_APP_WIFI_SECURE_SSID) && defined(MBED_CONF_APP_WIFI_UNSECURE_SSID)

TESTS/network/wifi/wifi_scan_null.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ using namespace utest::v1;
2626
void wifi_scan_null(void)
2727
{
2828
WiFiInterface *wifi = get_interface();
29-
TEST_ASSERT(wifi->scan(NULL, 0) >= 2);
29+
TEST_ASSERT(wifi->scan(NULL, 0) >= 1);
3030
}
3131

0 commit comments

Comments
 (0)