Skip to content

Commit 1133bfb

Browse files
Added argument-check to dns_get_interface_server.
Added argument-check to avoid accessing NULL pointer. The second argument 'interface_name' of this function can be NULL. And the argument 'interface_name' is used for the argument of strcmp() without checked. For example, LWIP::add_dns_server() calls dns_getserver(index - 1, NULL).
1 parent 83fa121 commit 1133bfb

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

connectivity/lwipstack/lwip/src/core/lwip_dns.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,9 @@ dns_get_interface_server(u8_t numdns, const char *interface_name)
491491
if (numdns >= DNS_MAX_SERVERS) {
492492
return IP_ADDR_ANY;
493493
}
494-
494+
if (interface_name == NULL) {
495+
return IP_ADDR_ANY;
496+
}
495497
for (interface_server = multihoming_dns_servers; interface_server != NULL; interface_server = interface_server->next) {
496498
if (!strcmp(interface_name, interface_server->interface_name)) {
497499
return &interface_server->dns_servers[numdns];

0 commit comments

Comments
 (0)