Skip to content

Commit 1fa2589

Browse files
author
Hasnain Virk
committed
Style correction
LinkADRReq parameters and certain parameters used camel case which is not the recommended style.
1 parent a6651b8 commit 1fa2589

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

features/lorawan/lorastack/mac/LoRaMacCommand.cpp

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -145,40 +145,40 @@ lorawan_status_t LoRaMacCommand::process_mac_commands(const uint8_t *payload, ui
145145
mlme_conf.nb_gateways = payload[mac_index++];
146146
break;
147147
case SRV_MAC_LINK_ADR_REQ: {
148-
adr_req_params_t linkAdrReq;
149-
int8_t linkAdrDatarate = DR_0;
150-
int8_t linkAdrTxPower = TX_POWER_0;
151-
uint8_t linkAdrNbRep = 0;
152-
uint8_t linkAdrNbBytesParsed = 0;
148+
adr_req_params_t link_adr_req;
149+
int8_t link_adr_dr = DR_0;
150+
int8_t link_adr_txpower = TX_POWER_0;
151+
uint8_t link_adr_nbtrans = 0;
152+
uint8_t link_adr_nb_bytes_pasred = 0;
153153

154154
// Fill parameter structure
155-
linkAdrReq.payload = &payload[mac_index - 1];
156-
linkAdrReq.payload_size = commands_size - (mac_index - 1);
157-
linkAdrReq.adr_enabled = mac_sys_params.adr_on;
158-
linkAdrReq.ul_dwell_time = mac_sys_params.uplink_dwell_time;
159-
linkAdrReq.current_datarate = mac_sys_params.channel_data_rate;
160-
linkAdrReq.current_tx_power = mac_sys_params.channel_tx_power;
161-
linkAdrReq.current_nb_rep = mac_sys_params.retry_num;
155+
link_adr_req.payload = &payload[mac_index - 1];
156+
link_adr_req.payload_size = commands_size - (mac_index - 1);
157+
link_adr_req.adr_enabled = mac_sys_params.adr_on;
158+
link_adr_req.ul_dwell_time = mac_sys_params.uplink_dwell_time;
159+
link_adr_req.current_datarate = mac_sys_params.channel_data_rate;
160+
link_adr_req.current_tx_power = mac_sys_params.channel_tx_power;
161+
link_adr_req.current_nb_trans = mac_sys_params.nb_trans;
162162

163163
// Process the ADR requests
164-
status = lora_phy.link_ADR_request(&linkAdrReq,
165-
&linkAdrDatarate,
166-
&linkAdrTxPower,
167-
&linkAdrNbRep,
168-
&linkAdrNbBytesParsed);
164+
status = lora_phy.link_ADR_request(&link_adr_req,
165+
&link_adr_dr,
166+
&link_adr_txpower,
167+
&link_adr_nbtrans,
168+
&link_adr_nb_bytes_pasred);
169169

170170
if ((status & 0x07) == 0x07) {
171-
mac_sys_params.channel_data_rate = linkAdrDatarate;
172-
mac_sys_params.channel_tx_power = linkAdrTxPower;
173-
mac_sys_params.retry_num = linkAdrNbRep;
171+
mac_sys_params.channel_data_rate = link_adr_dr;
172+
mac_sys_params.channel_tx_power = link_adr_txpower;
173+
mac_sys_params.nb_trans = link_adr_nbtrans;
174174
}
175175

176176
// Add the answers to the buffer
177-
for (uint8_t i = 0; i < (linkAdrNbBytesParsed / 5); i++) {
177+
for (uint8_t i = 0; i < (link_adr_nb_bytes_pasred / 5); i++) {
178178
ret_value = add_link_adr_ans(status);
179179
}
180180
// Update MAC index
181-
mac_index += linkAdrNbBytesParsed - 1;
181+
mac_index += link_adr_nb_bytes_pasred - 1;
182182
}
183183
break;
184184
case SRV_MAC_DUTY_CYCLE_REQ:

0 commit comments

Comments
 (0)