Skip to content

Commit 2f279dc

Browse files
geky0xc0170
authored andcommitted
Removed unnecessary dns_query functions
1 parent 3b1e136 commit 2f279dc

File tree

3 files changed

+2
-37
lines changed

3 files changed

+2
-37
lines changed

features/net/network-socket/NetworkStack.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,7 @@
2424
// Default NetworkStack operations
2525
int NetworkStack::gethostbyname(SocketAddress *address, const char *name)
2626
{
27-
nsapi_addr_t addr;
28-
int err = nsapi_dns_query(this, &addr, name);
29-
if (err) {
30-
return err;
31-
}
32-
33-
address->set_addr(addr);
34-
return 0;
27+
return nsapi_dns_query(this, address, name);
3528
}
3629

3730
int NetworkStack::setstackopt(int level, int optname, const void *optval, unsigned optlen)

features/net/network-socket/nsapi_dns.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ static int dns_scan_response(const uint8_t **p, nsapi_addr_t *addr, unsigned add
176176
}
177177

178178
// core query function
179-
int nsapi_dns_query_multiple(NetworkStack *stack,
179+
static int nsapi_dns_query_multiple(NetworkStack *stack,
180180
nsapi_addr_t *addr, unsigned addr_count,
181181
const char *host, nsapi_version_t version)
182182
{
@@ -299,13 +299,6 @@ int nsapi_dns_query(nsapi_stack_t *stack,
299299
return (result > 0) ? 0 : result;
300300
}
301301

302-
int nsapi_dns_query(NetworkStack *stack,
303-
nsapi_addr_t *addr, const char *host, nsapi_version_t version)
304-
{
305-
int result = nsapi_dns_query_multiple(stack, addr, 1, host, version);
306-
return (result > 0) ? 0 : result;
307-
}
308-
309302
int nsapi_dns_query(NetworkStack *stack,
310303
SocketAddress *address, const char *host, nsapi_version_t version)
311304
{

features/net/network-socket/nsapi_dns.h

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,9 @@ int nsapi_dns_query(nsapi_stack_t *stack, nsapi_addr_t *addr,
3737
#ifdef __cplusplus
3838
int nsapi_dns_query(nsapi_stack_t *stack, nsapi_addr_t *addr,
3939
const char *host);
40-
int nsapi_dns_query(NetworkStack *stack, nsapi_addr_t *addr,
41-
const char *host, nsapi_version_t version = NSAPI_IPv4);
4240
int nsapi_dns_query(NetworkStack *stack, SocketAddress *addr,
4341
const char *host, nsapi_version_t version = NSAPI_IPv4);
4442

45-
template <typename S>
46-
int nsapi_dns_query(S *stack, nsapi_addr_t *addr,
47-
const char *host, nsapi_version_t version = NSAPI_IPv4)
48-
{
49-
return nsapi_dns_query(nsapi_create_stack(stack), addr, host, version);
50-
}
51-
5243
template <typename S>
5344
int nsapi_dns_query(S *stack, SocketAddress *addr,
5445
const char *host, nsapi_version_t version = NSAPI_IPv4)
@@ -77,22 +68,10 @@ int nsapi_dns_query_multiple(nsapi_stack_t *stack,
7768
int nsapi_dns_query_multiple(nsapi_stack_t *stack,
7869
nsapi_addr_t *addr, unsigned addr_count,
7970
const char *host);
80-
int nsapi_dns_query_multiple(NetworkStack *stack,
81-
nsapi_addr_t *addr, unsigned addr_count,
82-
const char *host, nsapi_version_t version = NSAPI_IPv4);
8371
int nsapi_dns_query_multiple(NetworkStack *stack,
8472
SocketAddress *addr, unsigned addr_count,
8573
const char *host, nsapi_version_t version = NSAPI_IPv4);
8674

87-
template <typename S>
88-
int nsapi_dns_query_multiple(S *stack,
89-
nsapi_addr_t *addr, unsigned addr_count,
90-
const char *host, nsapi_version_t version = NSAPI_IPv4)
91-
{
92-
return nsapi_dns_query_multiple(nsapi_create_stack(stack),
93-
addr, addr_count, host, version);
94-
}
95-
9675
template <typename S>
9776
int nsapi_dns_query_multiple(S *stack,
9877
SocketAddress *addr, unsigned addr_count,

0 commit comments

Comments
 (0)