BLE: Warning cleanup

- Missing default assignment operator
- Field order in construction list
- Typo
- Unused header

Author: pan-

connectivity/FEATURE_BLE/include/ble/GattServer.h

@@ -507,7 +507,7 @@ class GattServer {
         void (T::*memberPtr)(const GattReadCallbackParams *context)
     )
     {
-        onDataRead({objPtr, memberPtr});
+        return onDataRead({objPtr, memberPtr});
     }
 
     /**

connectivity/FEATURE_BLE/include/ble/common/ble/UUID.h

@@ -235,6 +235,13 @@ class UUID {
         memcpy(baseUUID, source.baseUUID, LENGTH_OF_LONG_UUID);
     }
 
+    /**
+     * UUID copy assignment.
+     *
+     * @param[in] source The UUID to copy.
+     */
+    UUID& operator=(const UUID &source) = default;
+
     /**
      * Default constructor.
      *

connectivity/FEATURE_BLE/include/ble/common/ble/gap/AdvertisingDataParser.h

@@ -70,7 +70,7 @@ class AdvertisingDataParser {
      */
     bool hasNext() const
     {
-        if (position >= data.size()) {
+        if (position >= (size_t) data.size()) {
             return false;
         }
 
@@ -79,7 +79,7 @@ class AdvertisingDataParser {
             return false;
         }
 
-        if (position + current_length() >= data.size()) {
+        if (position + current_length() >= (size_t) data.size()) {
             return false;
         }
 

connectivity/FEATURE_BLE/include/ble/internal/SecurityDb.h

@@ -344,7 +344,7 @@ class SecurityDb {
         Span<SecurityEntryIdentity_t>& identity_list
     ) {
         size_t count = 0;
-        for (size_t i = 0; i < get_entry_count() && count < identity_list.size(); ++i) {
+        for (size_t i = 0; i < get_entry_count() && count < (size_t) identity_list.size(); ++i) {
 
             entry_handle_t db_handle = get_entry_handle_by_index(i);
             SecurityDistributionFlags_t* flags = get_distribution_flags(db_handle);

connectivity/FEATURE_BLE/libraries/TARGET_CORDIO/driver/CordioHCIDriver.cpp

@@ -17,8 +17,8 @@
 #include <stddef.h>
 #include <string.h>
 
-#include "ble/internal/BLEInstanceBase.h"
 #include "ble/BLE.h"
+#include "ble/internal/BLEInstanceBase.h"
 #include "ble/Gap.h"
 #include "CordioHCIDriver.h"
 #include "hci_api.h"

connectivity/FEATURE_BLE/libraries/TARGET_CORDIO/include/ble/internal/PalGapImpl.h

@@ -29,7 +29,7 @@ namespace ble {
  */
 class PalGap : public interface::PalGap {
 public:
-    PalGap() : use_active_scanning(false), _pal_event_handler(NULL) { };
+    PalGap() : _pal_event_handler(NULL), use_active_scanning(false) { };
     ~PalGap() { };
 
     bool is_feature_supported(

connectivity/FEATURE_BLE/libraries/ble-api-implementation/include/ble/internal/SecurityManagerImpl.h

@@ -454,16 +454,16 @@ class SecurityManager :
         PalSecurityManager &palImpl,
         PalConnectionMonitor &connMonitorImpl,
         PalSigningMonitor &signingMonitorImpl
-    ) : _pal(palImpl),
+    ) : eventHandler(nullptr),
+        _pal(palImpl),
         _connection_monitor(connMonitorImpl),
         _signing_monitor(signingMonitorImpl),
         _db(NULL),
         _default_authentication(0),
         _default_key_distribution(KeyDistribution::KEY_DISTRIBUTION_ALL),
         _pairing_authorisation_required(false),
         _legacy_pairing_allowed(true),
-        _master_sends_keys(false),
-        eventHandler(NULL)
+        _master_sends_keys(false)
     {
         eventHandler = &defaultEventHandler;
         _pal.set_event_handler(this);

connectivity/FEATURE_BLE/libraries/ble-api-implementation/source/GattClientImpl.cpp

@@ -1688,15 +1688,6 @@ void GattClient::onShutdown(const GattClientShutdownCallback_t &callback)
     shutdownCallChain.add(callback);
 }
 
-/**
- * @see GattClient::onShutdown
- */
-template<typename T>
-void GattClient::onShutdown(T *objPtr, void (T::*memberPtr)(const GattClient *))
-{
-    shutdownCallChain.add(objPtr, memberPtr);
-}
-
 /**
  * @see GattClient::onShutdown
  */

connectivity/FEATURE_BLE/libraries/ble-api-implementation/source/GattServerImpl.cpp

@@ -1384,9 +1384,9 @@ bool GattServer::is_update_authorized(
 }
 
 GattServer::GattServer() :
+    eventHandler(nullptr),
     serviceCount(0),
     characteristicCount(0),
-    eventHandler(nullptr),
     dataSentCallChain(),
     dataWrittenCallChain(),
     dataReadCallChain(),

connectivity/FEATURE_BLE/source/DiscoveredCharacteristic.cpp

@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+#include "ble/BLE.h"
 #include "ble/common/ble/DiscoveredCharacteristic.h"
 #include "ble/GattClient.h"