GigaDevice targets can return ninitialized variable in CAN driver

janjongboom · janjongboom · commit 49e970560d39 · 2019-03-07T16:41:42.000+01:00
diff --git a/targets/TARGET_GigaDevice/TARGET_GD32E10X/can_api.c b/targets/TARGET_GigaDevice/TARGET_GD32E10X/can_api.c
@@ -305,7 +305,7 @@ void can_free(can_t *obj)
  */
 int can_frequency(can_t *obj, int hz)
 {
-    int reval;
+    int reval = 0;
 
     /* The maximum baud rate support to 1M */
     if (hz <= 1000000) {
diff --git a/targets/TARGET_GigaDevice/TARGET_GD32F30X/can_api.c b/targets/TARGET_GigaDevice/TARGET_GD32F30X/can_api.c
@@ -305,7 +305,7 @@ void can_free(can_t *obj)
  */
 int can_frequency(can_t *obj, int hz)
 {
-    int reval;
+    int reval = 0;
 
     /* The maximum baud rate support to 1M */
     if (hz <= 1000000) {
diff --git a/targets/TARGET_GigaDevice/TARGET_GD32F4XX/can_api.c b/targets/TARGET_GigaDevice/TARGET_GD32F4XX/can_api.c
@@ -306,7 +306,7 @@ void can_free(can_t *obj)
  */
 int can_frequency(can_t *obj, int hz)
 {
-    int reval;
+    int reval = 0;
 
     /* The maximum baud rate support to 1M */
     if (hz <= 1000000) {

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ void can_free(can_t *obj)`
`305`	`305`	`*/`
`306`	`306`	`int can_frequency(can_t *obj, int hz)`
`307`	`307`	`{`
`308`		`- int reval;`
	`308`	`+ int reval = 0;`
`309`	`309`
`310`	`310`	`/* The maximum baud rate support to 1M */`
`311`	`311`	`if (hz <= 1000000) {`
Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ void can_free(can_t *obj)`
`306`	`306`	`*/`
`307`	`307`	`int can_frequency(can_t *obj, int hz)`
`308`	`308`	`{`
`309`		`- int reval;`
	`309`	`+ int reval = 0;`
`310`	`310`
`311`	`311`	`/* The maximum baud rate support to 1M */`
`312`	`312`	`if (hz <= 1000000) {`