Skip to content

Commit 6467f56

Browse files
committed
Fix Coverity uninitialized pointer field Thread.h
Changed _obj_mem to be initialized with constructor of new thread.
1 parent 101ae73 commit 6467f56

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rtos/source/Thread.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ void Thread::constructor(uint32_t tz_module, osPriority priority,
5151
const uint32_t offset = aligned_mem - unaligned_mem;
5252
const uint32_t aligned_size = ALIGN_DOWN(stack_size - offset, 8);
5353

54-
_tid = 0;
54+
memset(&_obj_mem, 0, sizeof(_obj_mem));
55+
_tid = nullptr;
5556
_dynamic_stack = (stack_mem == nullptr);
5657
_finished = false;
5758
memset(&_attr, 0, sizeof(_attr));
@@ -106,7 +107,6 @@ osStatus Thread::start(mbed::Callback<void()> task)
106107
((uint32_t *)_attr.stack_mem)[i] = osRtxStackMagicWord;
107108
}
108109

109-
memset(&_obj_mem, 0, sizeof(_obj_mem));
110110
_attr.cb_size = sizeof(_obj_mem);
111111
_attr.cb_mem = &_obj_mem;
112112
_task = task;

0 commit comments

Comments
 (0)