Merge pull request #2785 from pan-/remove_warnings_from_nordic_target

TARGET_NRF - Remove warnings from nordic target.

Author: sg-

features/FEATURE_BLE/ble/deprecate.h

@@ -23,4 +23,4 @@
 	#define __deprecated_message(msg)
 #endif
 
-#endif
+#endif

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/ble/common/ble_conn_state.c

@@ -169,7 +169,7 @@ static void record_purge_disconnected()
                                    m_bcs.valid_conn_handles,
                                  (~m_bcs.flags.connected_flags) & (m_bcs.flags.valid_flags));
 
-    for (int i = 0; i < disconnected_list.len; i++)
+    for (uint32_t i = 0; i < disconnected_list.len; i++)
     {
         record_invalidate(disconnected_list.flag_keys[i]);
     }

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/ble/peer_manager/peer_database.c

@@ -172,7 +172,7 @@ static pdb_buffer_record_t * write_buffer_record_find_unused(void)
  */
 static void write_buffer_record_release(pdb_buffer_record_t * p_write_buffer_record)
 {
-    for (int i = 0; i < p_write_buffer_record->n_bufs; i++)
+    for (uint32_t i = 0; i < p_write_buffer_record->n_bufs; i++)
     {
         pm_buffer_release(&m_pdb.write_buffer, p_write_buffer_record->buffer_block_id + i);
     }

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/ble/peer_manager/pm_buffer.c

@@ -93,7 +93,7 @@ uint8_t pm_buffer_block_acquire(pm_buffer_t * p_buffer, uint32_t n_blocks)
             {
                 first_locked_mutex = i;
             }
-            if ((i - first_locked_mutex + 1) == n_blocks)
+            if ((i - first_locked_mutex + 1) >= 0 && ((uint32_t)(i - first_locked_mutex + 1)) == n_blocks)
             {
                 return first_locked_mutex;
             }

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/drivers_nrf/delay/nrf_delay.h

@@ -191,8 +191,8 @@ __STATIC_INLINE void nrf_delay_us(uint32_t volatile number_of_us)
 
 #elif defined ( __GNUC__ )
 
-static void __INLINE nrf_delay_us(uint32_t volatile number_of_us) __attribute__((always_inline));
-static void __INLINE nrf_delay_us(uint32_t volatile number_of_us)
+static __INLINE void nrf_delay_us(uint32_t volatile number_of_us) __attribute__((always_inline));
+static __INLINE void nrf_delay_us(uint32_t volatile number_of_us)
 {
 register uint32_t delay __ASM ("r0") = number_of_us;
 __ASM volatile (

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/libraries/fds/fds.c

@@ -40,6 +40,10 @@
 #include "nrf_error.h"
 #include "app_util.h"
 
+static void fs_callback(uint8_t             op_code,
+                        uint32_t            result,
+                        uint32_t    const * p_data,
+                        fs_length_t         length_words);
 
 /** Our fstorage configuration.
  *  The other fields will be assigned automatically during compilation. */

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/libraries/fds/fds_types_internal.h

@@ -68,7 +68,7 @@
 #define FDS_CMD_QUEUE_SIZE_GC       (1)
 
 
-static uint8_t m_nested_critical;
+//static uint8_t m_nested_critical;
 
 /** Macros to enable and disable application interrupts. */
 #define CRITICAL_SECTION_ENTER()    //sd_nvic_critical_region_enter(&m_nested_critical)

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/libraries/fstorage/fstorage.c

@@ -559,7 +559,7 @@ void fs_debug_print()
     printf("Num items: 0x%08lx\r\n",        (unsigned long)FS_SECTION_VARS_COUNT);
     printf("===== ITEMS %lu =====\r\n",     (unsigned long)FS_SECTION_VARS_COUNT);
 
-    for(int i = 0; i < FS_SECTION_VARS_COUNT; i++)
+    for(uint32_t i = 0; i < FS_SECTION_VARS_COUNT; i++)
     {
         fs_config_t* config = FS_SECTION_VARS_GET(i);
         printf( "Address: 0x%08lx, CB: 0x%08lx\r\n",

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/libraries/fstorage/fstorage.h

@@ -74,23 +74,6 @@ typedef void (*fs_cb_t)(uint8_t             op_code,
                         fs_length_t         length_words);
 
 
-/**@brief Function prototype for a callback handler.
- *
- * @details This function is expected to be implemented by the module that 
- *          registers for fstorage usage. Its usage is described
- *          in the function pointer type fs_cb_t.
- *
- * @param[in]   op_code         Flash operation code.
- * @param[in]   result          Result of the flash operation.
- * @param[in]   p_data          Pointer to the resulting data (or NULL if not in use).
- * @param[in]   length_words    Length of data in words.
- */
-static void fs_callback(uint8_t             op_code,
-                        uint32_t            result,
-                        uint32_t    const * p_data,
-                        fs_length_t         length_words);
-
-
 /**@brief Flash storage config variable.
  *
  * @details     The fstorage module will update the start_addr and end_address according to 

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/sdk/source/libraries/util/app_util_platform.h

@@ -68,8 +68,6 @@ typedef enum
 #define EXTERNAL_INT_VECTOR_OFFSET 16
 /**@endcond */
 
-#define PACKED(TYPE) __packed TYPE
-
 void critical_region_enter (void);
 void critical_region_exit (void);