fix releaseing the WSF msg too early

paul-szczepanek-arm · 0xc0170 · commit 7894a9321df7 · 2019-05-27T06:16:49.000+01:00
diff --git a/features/FEATURE_BLE/targets/TARGET_CORDIO/stack_adaptation/hci_tr.c b/features/FEATURE_BLE/targets/TARGET_CORDIO/stack_adaptation/hci_tr.c
@@ -66,11 +66,12 @@ void hciTrSendAclData(void *pContext, uint8_t *pData)
   HCI_PDUMP_TX_ACL(len, pData);
 
   /* transmit ACL header and data */
-  if (hciDrvWrite(HCI_ACL_TYPE, len, pData) == len)
+  if (hciDrvWrite(HCI_ACL_TYPE, len, pData) != len)
   {
-    /* free buffer */
-    hciCoreTxAclComplete(pContext, pData);
+    /* transport failure */
+    WSF_ASSERT(0);
   }
+  /* pData is not freed as the hciDrvWrite took ownership of the WSF buffer */
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -66,11 +66,12 @@ void hciTrSendAclData(void pContext, uint8_t pData)`
`66`	`66`	`HCI_PDUMP_TX_ACL(len, pData);`
`67`	`67`
`68`	`68`	`/* transmit ACL header and data */`
`69`		`- if (hciDrvWrite(HCI_ACL_TYPE, len, pData) == len)`
	`69`	`+ if (hciDrvWrite(HCI_ACL_TYPE, len, pData) != len)`
`70`	`70`	`{`
`71`		`- /* free buffer */`
`72`		`- hciCoreTxAclComplete(pContext, pData);`
	`71`	`+ /* transport failure */`
	`72`	`+ WSF_ASSERT(0);`
`73`	`73`	`}`
	`74`	`+ /* pData is not freed as the hciDrvWrite took ownership of the WSF buffer */`
`74`	`75`	`}`
`75`	`76`
`76`	`77`