LoRaWAN: Memory overrun correction

Hasnain Virk · Hasnain Virk · commit 7b7d5ebc77e5 · 2018-09-04T15:21:40.000+03:00
A typo in LoRaPHYCN470 is causing memory overrun.
We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.
diff --git a/features/lorawan/lorastack/phy/LoRaPHYCN470.cpp b/features/lorawan/lorastack/phy/LoRaPHYCN470.cpp
@@ -220,7 +220,7 @@ LoRaPHYCN470::LoRaPHYCN470()
     }
 
     // Initialize the channels default mask
-    for (uint8_t i = 0; i < CN470_MAX_NB_CHANNELS; i++) {
+    for (uint8_t i = 0; i < CN470_CHANNEL_MASK_SIZE; i++) {
         default_channel_mask[i] = 0xFFFF & fsb_mask[i];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ LoRaPHYCN470::LoRaPHYCN470()`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`// Initialize the channels default mask`
`223`		`- for (uint8_t i = 0; i < CN470_MAX_NB_CHANNELS; i++) {`
	`223`	`+ for (uint8_t i = 0; i < CN470_CHANNEL_MASK_SIZE; i++) {`
`224`	`224`	`default_channel_mask[i] = 0xFFFF & fsb_mask[i];`
`225`	`225`	`}`
`226`	`226`