Skip to content

Commit 7bc411e

Browse files
ytsuboiadbridge
authored andcommitted
Changed suggested things
Removed context check from do_user_authentication.
1 parent b3ebb52 commit 7bc411e

File tree

3 files changed

+1
-11
lines changed

3 files changed

+1
-11
lines changed

features/cellular/framework/AT/AT_CellularNetwork.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -437,11 +437,6 @@ void AT_CellularNetwork::ppp_status_cb(nsapi_event_t event, intptr_t parameter)
437437

438438
nsapi_error_t AT_CellularNetwork::do_user_authentication()
439439
{
440-
// try to find or create context with suitable stack
441-
if (!get_context()) {
442-
return NSAPI_ERROR_NO_CONNECTION;
443-
}
444-
445440
// if user has defined user name and password we need to call CGAUTH before activating or modifying context
446441
if (_pwd && _uname) {
447442
_at.cmd_start("AT+CGAUTH=");

features/cellular/framework/AT/AT_CellularNetwork.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ class AT_CellularNetwork : public CellularNetwork, public AT_CellularBase
154154
void free_credentials();
155155

156156
nsapi_error_t open_data_channel();
157+
bool get_context();
157158
bool set_new_context(int cid);
158159

159160
nsapi_error_t delete_current_context();
@@ -179,7 +180,6 @@ class AT_CellularNetwork : public CellularNetwork, public AT_CellularBase
179180
int _cell_id;
180181
nsapi_connection_status_t _connect_status;
181182
virtual nsapi_error_t do_user_authentication();
182-
bool get_context();
183183
bool _new_context_set;
184184
bool _is_context_active;
185185
RegistrationStatus _reg_status;

features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96_CellularNetwork.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@ nsapi_error_t QUECTEL_UG96_CellularNetwork::set_access_technology_impl(RadioAcce
4545

4646
nsapi_error_t QUECTEL_UG96_CellularNetwork::do_user_authentication()
4747
{
48-
// try to find or create context with suitable stack
49-
if (!get_context()) {
50-
return NSAPI_ERROR_NO_CONNECTION;
51-
}
52-
5348
if (_pwd && _uname) {
5449
_at.cmd_start("AT+QICSGP=");
5550
_at.write_int(_cid);

0 commit comments

Comments
 (0)