Add standard pin-names validation script & tests

Author: gpsimenos

.codecheckignore

@@ -19,6 +19,7 @@
 ^hal/storage_abstraction
 ^hal/tests/TESTS/mbed_hal/trng/pithy
 ^hal/tests/TESTS/mbed_hal/trng/pithy
+^hal/tests/TESTS/pin_names/test_files
 ^platform/cxxsupport
 ^platform/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_MBED_PSA_SRV
 ^platform/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM

.travis.yml

@@ -321,3 +321,25 @@ matrix:
             CFLAGS+="-DLFS_NO_ASSERT -DLFS_NO_DEBUG -DLFS_NO_WARN -DLFS_NO_ERROR"
             | tee sizes
         - ccache -s
+    - <<: extended-pinvalidate
+      stage: "Extended"
+      name: "pinvalidate"
+      env: NAME=pinvalidate
+      language: python
+      python: 3.7
+      install:
+        # Install python modules
+        - python -m pip install --upgrade pip==18.1
+        - python -m pip install --upgrade setuptools==40.4.3
+        - pip install tabulate argparse
+        - pip list --verbose
+        # Fetch remaining information needed for branch comparison
+        - git fetch --all --unshallow --tags
+        - git fetch origin "${TRAVIS_BRANCH}"
+      script:
+        - >-
+          git diff --name-only --diff-filter=d FETCH_HEAD..HEAD \
+            | ( grep '.*[\\|\/]PinNames.h$' || true ) \
+            | while read file; do python ./hal/tests/TESTS/pin_names/pinvalidate.py -vfp "${file}"; done
+        - git diff --exit-code --diff-filter=d --color
+

hal/source/mbed_pinmap_default.cpp

@@ -43,7 +43,7 @@ static const PinList ff_arduino_uno_list = {
     ff_arduino_uno_pins
 };
 
-static_assert(sizeof(ff_arduino_pins) / sizeof(ff_arduino_pins[0]) == sizeof(ff_arduino_names) / sizeof(ff_arduino_names[0]),
+static_assert(sizeof(ff_arduino_uno_pins) / sizeof(ff_arduino_uno_pins[0]) == sizeof(ff_arduino_uno_names) / sizeof(ff_arduino_uno_names[0]),
               "Arrays must have the same length");
 
 const PinList *pinmap_ff_arduino_uno_pins()

hal/tests/TESTS/mbed_hal/gpio/CMakeLists.txt

@@ -24,14 +24,10 @@
 Requirements specified in docs/design-documents/hal/0005-pin-names-Arduino-Uno-standard.md
 */
 
-#if !(defined (TARGET_FF_ARDUINO) || (TARGET_FF_ARDUINO_UNO))
+#if !(defined (TARGET_FF_ARDUINO_UNO))
 #error [NOT_SUPPORTED] Test needs Arduino Uno form factor
 #else
 
-#if defined (TARGET_FF_ARDUINO)
-#warning ARDUINO form factor should not be used any more => use ARDUINO_UNO
-#endif
-
 using namespace utest::v1;
 
 template <PinName TestedPin>
@@ -190,8 +186,6 @@ void I2C_test()
     }
 
     I2C i2c(SDA_pin, SCL_pin);
-    // Basic API call
-    i2c.read(0);
 }