Skip to content

Commit 98a27a6

Browse files
author
Cruz Monrreal
authored
Merge pull request #7054 from VeijoPesonen/gethostbyname_empty_hostname_check
gethostbyname must reject empty name
2 parents 24cebba + 3e6bc32 commit 98a27a6

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

TESTS/netsocket/udp/main.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ Case cases[] = {
9090
Case("UDPSOCKET_OPEN_LIMIT", UDPSOCKET_OPEN_LIMIT),
9191
Case("UDPSOCKET_SENDTO_TIMEOUT", UDPSOCKET_SENDTO_TIMEOUT),
9292
#ifdef MBED_EXTENDED_TESTS
93+
Case("UDPSOCKET_SENDTO_INVALID", UDPSOCKET_SENDTO_INVALID),
9394
Case("UDPSOCKET_ECHOTEST", UDPSOCKET_ECHOTEST),
9495
Case("UDPSOCKET_ECHOTEST_BURST", UDPSOCKET_ECHOTEST_BURST),
9596
Case("UDPSOCKET_ECHOTEST_BURST_NONBLOCK", UDPSOCKET_ECHOTEST_BURST_NONBLOCK),

features/netsocket/NetworkStack.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ const char *NetworkStack::get_ip_address()
2828
}
2929
nsapi_error_t NetworkStack::gethostbyname(const char *name, SocketAddress *address, nsapi_version_t version)
3030
{
31+
if (name[0] == '\0') {
32+
return NSAPI_ERROR_PARAMETER;
33+
}
34+
3135
// check for simple ip addresses
3236
if (address->set_ip_address(name)) {
3337
if (version != NSAPI_UNSPEC && address->get_ip_version() != version) {
@@ -53,6 +57,10 @@ nsapi_value_or_error_t NetworkStack::gethostbyname_async(const char *name, hostb
5357
{
5458
SocketAddress address;
5559

60+
if (name[0] == '\0') {
61+
return NSAPI_ERROR_PARAMETER;
62+
}
63+
5664
// check for simple ip addresses
5765
if (address.set_ip_address(name)) {
5866
if (version != NSAPI_UNSPEC && address.get_ip_version() != version) {

0 commit comments

Comments
 (0)