Unified the LED error pattern for all boards

  - Removed the patterned LED sequence, all boards now use the 4 fast pulse, 4 slow pulses LED sequence.
  - Changed the LED used from LED_RED to LED1. Only 58/174 targets seem to define LED_RED but they all define LED1.
  - Removed all ERROR_RED and ERROR_PATTERN definitions from targets/targets.json

Author: Steve Cartmell

platform/mbed_board.c

@@ -30,43 +30,22 @@ WEAK void mbed_die(void) {
 #if !defined (NRF51_H) && !defined(TARGET_EFM32)
     core_util_critical_section_enter();
 #endif
-#if   (DEVICE_ERROR_RED == 1)
-    gpio_t led_red; gpio_init_out(&led_red, LED_RED);
-#elif (DEVICE_ERROR_PATTERN == 1)
-    gpio_t led_1; gpio_init_out(&led_1, LED1);
-    gpio_t led_2; gpio_init_out(&led_2, LED2);
-    gpio_t led_3; gpio_init_out(&led_3, LED3);
-    gpio_t led_4; gpio_init_out(&led_4, LED4);
-#endif
+    gpio_t led_err; gpio_init_out(&led_err, LED1);
 
     while (1) {
-#if   (DEVICE_ERROR_RED == 1)
         for (int i = 0; i < 4; ++i) {
-            gpio_write(&led_red, 1);
+            gpio_write(&led_err, 1);
             wait_ms(150);
-            gpio_write(&led_red, 0);
+            gpio_write(&led_err, 0);
             wait_ms(150);
         }
 
         for (int i = 0; i < 4; ++i) {
-            gpio_write(&led_red, 1);
+            gpio_write(&led_err, 1);
             wait_ms(400);
-            gpio_write(&led_red, 0);
+            gpio_write(&led_err, 0);
             wait_ms(400);
         }
-#elif (DEVICE_ERROR_PATTERN == 1)
-        gpio_write(&led_1, 1);
-        gpio_write(&led_2, 0);
-        gpio_write(&led_3, 0);
-        gpio_write(&led_4, 1);
-        wait_ms(150);
-
-        gpio_write(&led_1, 0);
-        gpio_write(&led_2, 1);
-        gpio_write(&led_3, 1);
-        gpio_write(&led_4, 0);
-        wait_ms(150);
-#endif
     }
 }