Skip to content

Commit a0c5389

Browse files
ccli8ccli8
committed
Nuvoton: Enable no HXT/LXT configurabiliy
LXT/HXT are external crystl oscillator and can be absent on custom board. This enables configuring LXT/HXT presence: 1. By default, LXT/HXT are configured to be present, except M252 which has no HXT. 2. When LXT is configured to not present, lp_ticker/watchdog will clock by LIRC instead. 3. Limitations: (1) On all targets, LIRC-clocked lp_ticker gets inaccurate and fails to pass tests. (2) On NUC472/M453, HIRC-clocked PLL doesn't output 1MHz-aligned frequency. us_ticker gets slight inaccurate. (3) On all targets, LIRC-clocked RTC is not supported due to no H/W path/RTC clock source reset to LXT on reset/RTC not trimmed for other clock rates. 4. On M263, TRNG's clock source defaults to LXT and needs special handling without LXT. 5. On M252, replace target.hxt-enable with target.hxt-present for consistency.
1 parent 0738aab commit a0c5389

32 files changed

+348
-99
lines changed

‎targets/TARGET_NUVOTON/TARGET_M251/device/system_M251.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ extern "C" {
5050
#define __HSI (48000000UL) /*!< PLL default output is 48MHz */
5151
#define __SYS_OSC_CLK ( ___HSI) /*!< Main oscillator frequency */
5252

53+
#if MBED_CONF_TARGET_HXT_PRESENT
5354
#define __SYSTEM_CLOCK (1UL*__HXT)
55+
#else
56+
#define __SYSTEM_CLOCK (1UL*__HIRC)
57+
#endif
5458

5559
extern uint32_t SystemCoreClock; /*!< System Clock Frequency (Core Clock) */
5660
extern uint32_t CyclesPerUs; /*!< Cycles per micro second */

‎targets/TARGET_NUVOTON/TARGET_M251/lp_ticker.c‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@
3131
/* Timer clock per lp_ticker tick */
3232
#define NU_TMRCLK_PER_TICK 1
3333
/* Timer clock per second */
34+
#if MBED_CONF_TARGET_LXT_PRESENT
3435
#define NU_TMRCLK_PER_SEC (__LXT)
36+
#else
37+
#define NU_TMRCLK_PER_SEC (__LIRC)
38+
#endif
3539
/* Timer max counter bit size */
3640
#define NU_TMR_MAXCNT_BITSIZE 24
3741
/* Timer max counter */
@@ -40,7 +44,11 @@
4044
static void tmr1_vec(void);
4145

4246
/* NOTE: To wake the system from power down mode, timer clock source must be ether LXT or LIRC. */
47+
#if MBED_CONF_TARGET_LXT_PRESENT
4348
static const struct nu_modinit_s timer1_modinit = {TIMER_1, TMR1_MODULE, CLK_CLKSEL1_TMR1SEL_LXT, 0, TMR1_RST, TMR1_IRQn, (void *) tmr1_vec};
49+
#else
50+
static const struct nu_modinit_s timer1_modinit = {TIMER_1, TMR1_MODULE, CLK_CLKSEL1_TMR1SEL_LIRC, 0, TMR1_RST, TMR1_IRQn, (void *) tmr1_vec};
51+
#endif
4452

4553
#define TIMER_MODINIT timer1_modinit
4654

‎targets/TARGET_NUVOTON/TARGET_M251/mbed_overrides.c‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,47 +33,55 @@ void mbed_sdk_init(void)
3333
/* Unlock protected registers */
3434
SYS_UnlockReg();
3535

36-
#if defined(NU_HXT_ENABLE) && (NU_HXT_ENABLE == 1UL)
36+
#if MBED_CONF_TARGET_HXT_PRESENT
3737
/* HXT Enable: Set XT1_OUT(PF.2) and XT1_IN(PF.3) to input mode */
3838
PF->MODE &= ~(GPIO_MODE_MODE2_Msk | GPIO_MODE_MODE3_Msk);
3939
#endif
4040

41+
#if MBED_CONF_TARGET_LXT_PRESENT
4142
/* LXT Enable: Set X32_OUT(PF.4) and X32_IN(PF.5) to input mode */
4243
PF->MODE &= ~(GPIO_MODE_MODE4_Msk | GPIO_MODE_MODE5_Msk);
44+
#endif
4345

4446
/* Enable HIRC clock (Internal RC 48MHz) */
4547
CLK_EnableXtalRC(CLK_PWRCTL_HIRCEN_Msk);
46-
#if defined(NU_HXT_ENABLE) && (NU_HXT_ENABLE == 1UL)
48+
#if MBED_CONF_TARGET_HXT_PRESENT
4749
/* Enable HXT clock (external XTAL 12MHz) */
4850
CLK_EnableXtalRC(CLK_PWRCTL_HXTEN_Msk);
4951
#endif
50-
/* Enable LIRC for lp_ticker */
52+
/* Enable LIRC */
5153
CLK_EnableXtalRC(CLK_PWRCTL_LIRCEN_Msk);
52-
/* Enable LXT for RTC */
54+
#if MBED_CONF_TARGET_LXT_PRESENT
55+
/* Enable LXT */
5356
CLK_EnableXtalRC(CLK_PWRCTL_LXTEN_Msk);
57+
#endif
5458

5559
/* Wait for HIRC clock ready */
5660
CLK_WaitClockReady(CLK_STATUS_HIRCSTB_Msk);
57-
#if defined(NU_HXT_ENABLE) && (NU_HXT_ENABLE == 1UL)
61+
#if MBED_CONF_TARGET_HXT_PRESENT
5862
/* Wait for HXT clock ready */
5963
CLK_WaitClockReady(CLK_STATUS_HXTSTB_Msk);
6064
#endif
6165
/* Wait for LIRC clock ready */
6266
CLK_WaitClockReady(CLK_STATUS_LIRCSTB_Msk);
67+
#if MBED_CONF_TARGET_LXT_PRESENT
6368
/* Wait for LXT clock ready */
6469
CLK_WaitClockReady(CLK_STATUS_LXTSTB_Msk);
70+
#endif
6571

66-
#if defined(NU_HXT_ENABLE) && (NU_HXT_ENABLE == 1UL)
72+
#if MBED_CONF_TARGET_HXT_PRESENT
6773
/* HXT Enable: Disable digital input path of analog pin XT1_OUT to prevent leakage */
6874
GPIO_DISABLE_DIGITAL_PATH(PF, (1ul << 2));
6975
/* HXT Enable: Disable digital input path of analog pin XT1_IN to prevent leakage */
7076
GPIO_DISABLE_DIGITAL_PATH(PF, (1ul << 3));
7177
#endif
7278

79+
#if MBED_CONF_TARGET_LXT_PRESENT
7380
/* LXT Enable: Disable digital input path of analog pin X32_OUT to prevent leakage */
7481
GPIO_DISABLE_DIGITAL_PATH(PF, (1ul << 4));
7582
/* LXT Enable: Disable digital input path of analog pin XT32_IN to prevent leakage */
7683
GPIO_DISABLE_DIGITAL_PATH(PF, (1ul << 5));
84+
#endif
7785

7886
/* Select HCLK clock source as HIRC and HCLK clock divider as 1 */
7987
CLK_SetHCLK(CLK_CLKSEL0_HCLKSEL_HIRC, CLK_CLKDIV0_HCLK(1));

‎targets/TARGET_NUVOTON/TARGET_M251/rtc_api.c‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@
2626
#include "nu_miscutil.h"
2727
#include "mbed_mktime.h"
2828

29+
/* Not support LIRC-clocked RTC
30+
*
31+
* H/W doesn't support this path.
32+
*/
33+
#if !MBED_CONF_TARGET_LXT_PRESENT
34+
#error "RTC can only clock by LXT but LXT is not present. Try disabling RTC by \"device_has_remove\" in mbed_app.json"
35+
#endif
36+
2937
/* Micro seconds per second */
3038
#define NU_US_PER_SEC 1000000
3139
/* Timer clock per second

‎targets/TARGET_NUVOTON/TARGET_M261/lp_ticker.c‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@
3030
/* Timer clock per lp_ticker tick */
3131
#define NU_TMRCLK_PER_TICK 1
3232
/* Timer clock per second */
33+
#if MBED_CONF_TARGET_LXT_PRESENT
3334
#define NU_TMRCLK_PER_SEC (__LXT)
35+
#else
36+
#define NU_TMRCLK_PER_SEC (__LIRC)
37+
#endif
3438
/* Timer max counter bit size */
3539
#define NU_TMR_MAXCNT_BITSIZE 24
3640
/* Timer max counter */
@@ -40,7 +44,11 @@
4044
static void tmr1_vec(void);
4145

4246
/* NOTE: To wake the system from power down mode, timer clock source must be ether LXT or LIRC. */
47+
#if MBED_CONF_TARGET_LXT_PRESENT
4348
static const struct nu_modinit_s timer1_modinit = {TIMER_1, TMR1_MODULE, CLK_CLKSEL1_TMR1SEL_LXT, 0, TMR1_RST, TMR1_IRQn, (void *) tmr1_vec};
49+
#else
50+
static const struct nu_modinit_s timer1_modinit = {TIMER_1, TMR1_MODULE, CLK_CLKSEL1_TMR1SEL_LIRC, 0, TMR1_RST, TMR1_IRQn, (void *) tmr1_vec};
51+
#endif
4452

4553
#define TIMER_MODINIT timer1_modinit
4654

‎targets/TARGET_NUVOTON/TARGET_M261/mbed_overrides.c‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,31 @@ void mbed_sdk_init(void)
3636

3737
/* Enable HIRC clock (Internal RC 12MHz) */
3838
CLK_EnableXtalRC(CLK_PWRCTL_HIRCEN_Msk);
39+
#if MBED_CONF_TARGET_HXT_PRESENT
3940
/* Enable HXT clock (external XTAL 12MHz) */
4041
CLK_EnableXtalRC(CLK_PWRCTL_HXTEN_Msk);
41-
/* Enable LIRC for lp_ticker */
42+
#endif
43+
/* Enable LIRC */
4244
CLK_EnableXtalRC(CLK_PWRCTL_LIRCEN_Msk);
43-
/* Enable LXT for RTC */
45+
#if MBED_CONF_TARGET_LXT_PRESENT
46+
/* Enable LXT */
4447
CLK_EnableXtalRC(CLK_PWRCTL_LXTEN_Msk);
48+
#endif
4549
/* Enable HIRC48 clock (Internal RC 48MHz) */
4650
CLK_EnableXtalRC(CLK_PWRCTL_HIRC48EN_Msk);
4751

4852
/* Wait for HIRC clock ready */
4953
CLK_WaitClockReady(CLK_STATUS_HIRCSTB_Msk);
54+
#if MBED_CONF_TARGET_HXT_PRESENT
5055
/* Wait for HXT clock ready */
5156
CLK_WaitClockReady(CLK_STATUS_HXTSTB_Msk);
57+
#endif
5258
/* Wait for LIRC clock ready */
5359
CLK_WaitClockReady(CLK_STATUS_LIRCSTB_Msk);
60+
#if MBED_CONF_TARGET_LXT_PRESENT
5461
/* Wait for LXT clock ready */
5562
CLK_WaitClockReady(CLK_STATUS_LXTSTB_Msk);
63+
#endif
5664
/* Wait for HIRC48 clock ready */
5765
CLK_WaitClockReady(CLK_STATUS_HIRC48STB_Msk);
5866

‎targets/TARGET_NUVOTON/TARGET_M261/rtc_api.c‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,27 @@
2525
#include "nu_miscutil.h"
2626
#include "mbed_mktime.h"
2727

28+
/* Not support LIRC-clocked RTC
29+
*
30+
* Though H/W supports this path, it is still not supported because:
31+
* 1. RTC is trimmed only for 32.768 KHz LXT, not for other clock rates.
32+
* 2. RTC's clock source will reset to default LXT on reset. This results in rtc_reset test failing.
33+
*/
34+
#if !MBED_CONF_TARGET_LXT_PRESENT
35+
#error "RTC can only clock by LXT but LXT is not present. Try disabling RTC by \"device_has_remove\" in mbed_app.json"
36+
#endif
37+
2838
/* Micro seconds per second */
2939
#define NU_US_PER_SEC 1000000
3040
/* Timer clock per second
3141
*
3242
* NOTE: This dependents on real hardware.
3343
*/
44+
#if MBED_CONF_TARGET_LXT_PRESENT
3445
#define NU_RTCCLK_PER_SEC __LXT
46+
#else
47+
#define NU_RTCCLK_PER_SEC __LIRC
48+
#endif
3549

3650
/* Strategy for implementation of RTC HAL
3751
*
@@ -85,7 +99,11 @@ static time_t t_write = 0;
8599
/* Convert date time from H/W RTC to struct TM */
86100
static void rtc_convert_datetime_hwrtc_to_tm(struct tm *datetime_tm, const S_RTC_TIME_DATA_T *datetime_hwrtc);
87101

102+
#if MBED_CONF_TARGET_LXT_PRESENT
88103
static const struct nu_modinit_s rtc_modinit = {RTC_0, RTC_MODULE, CLK_CLKSEL3_RTCSEL_LXT, 0, 0, RTC_IRQn, NULL};
104+
#else
105+
static const struct nu_modinit_s rtc_modinit = {RTC_0, RTC_MODULE, CLK_CLKSEL3_RTCSEL_LIRC, 0, 0, RTC_IRQn, NULL};
106+
#endif
89107

90108
void rtc_init(void)
91109
{

‎targets/TARGET_NUVOTON/TARGET_M261/trng_api.cpp‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,25 @@ void trng_init(MBED_UNUSED trng_t *obj)
4848
/* Reset IP */
4949
SYS_ResetModule(trng_modinit.rsetidx);
5050

51+
#if MBED_CONF_TARGET_LXT_PRESENT
52+
/* 32K clock from (external) LXT */
53+
#else
54+
/* 32K clock from LIRC32 */
55+
56+
/* Unlock protected registers */
57+
SYS_UnlockReg();
58+
59+
/* To access RTC registers, clock must be enabled first. */
60+
CLK_EnableModuleClock(RTC_MODULE);
61+
62+
/* Enable 32K clock from LIRC32 */
63+
RTC->LXTCTL |= (RTC_LXTCTL_C32KS_Msk | RTC_LXTCTL_LIRC32KEN_Msk);
64+
CLK_WaitClockReady(CLK_STATUS_LIRC32STB_Msk | CLK_STATUS_LXTSTB_Msk);
65+
66+
/* Lock protected registers */
67+
SYS_LockReg();
68+
#endif
69+
5170
TRNG_T *trng_base = (TRNG_T *) NU_MODBASE(trng_modinit.modname);
5271

5372
trng_base->ACT |= TRNG_ACT_ACT_Msk;

‎targets/TARGET_NUVOTON/TARGET_M451/device/startup_M451Series.c‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,12 @@ void Reset_Handler(void)
265265

266266
/* Disable Power-on Reset function */
267267
SYS_DISABLE_POR();
268-
268+
269+
#if MBED_CONF_TARGET_HXT_PRESENT
269270
/* HXT Crystal Type Select: INV */
270271
CLK->PWRCTL &= ~CLK_PWRCTL_HXTSELTYP_Msk;
271-
272+
#endif
273+
272274
/**
273275
* NOTE 1: Unlock is required for perhaps some register access in SystemInit().
274276
* NOTE 2: Because EBI (external SRAM) init is done in SystemInit(), SystemInit() must be called at the very start.

‎targets/TARGET_NUVOTON/TARGET_M451/device/system_M451Series.c‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,10 @@ void SystemInit(void)
8484
{
8585
M32(GCR_BASE+0x14) |= BIT7;
8686
}
87+
#if MBED_CONF_TARGET_HXT_PRESENT
8788
/* Force to use INV type with HXT */
8889
CLK->PWRCTL &= ~CLK_PWRCTL_HXTSELTYP_Msk;
90+
#endif
8991
SYS_LockReg();
9092

9193

0 commit comments

Comments
 (0)