Cellular: Fix AT Handler compile warning

Mirela Chirica · Mirela Chirica · commit a0cc22ebbaf0 · 2018-04-27T14:38:14.000+03:00
diff --git a/features/cellular/framework/AT/ATHandler.cpp b/features/cellular/framework/AT/ATHandler.cpp
@@ -483,7 +483,7 @@ ssize_t ATHandler::read(char *buf, size_t size, bool read_even_stop_tag, bool he
     size_t buf_idx = 0;
 
     for (; read_idx < (read_size + match_pos); read_idx++) {
-        char c = get_char();
+        int c = get_char();
         buf_idx = hex ? read_idx/2 : read_idx;
         if (c == -1) {
             pbuf[buf_idx] = '\0';
@@ -515,15 +515,15 @@ ssize_t ATHandler::read(char *buf, size_t size, bool read_even_stop_tag, bool he
            pbuf[buf_idx] = c;
         } else {
             if (read_idx % 2 == 0) {
-                upper = hex_str_to_int(&c, 1);
+                upper = hex_str_to_int((const char*)&c, 1);
             } else {
-                lower = hex_str_to_int(&c, 1);
+                lower = hex_str_to_int((const char*)&c, 1);
                 pbuf[buf_idx] = ((upper<<4) & 0xF0) | (lower & 0x0F);
             }
         }
     }
 
-    return buf_idx + 1;
+    return buf_idx;
 }
 
 ssize_t ATHandler::read_string(char *buf, size_t size, bool read_even_stop_tag)

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ ssize_t ATHandler::read(char *buf, size_t size, bool read_even_stop_tag, bool he`
`483`	`483`	`size_t buf_idx = 0;`
`484`	`484`
`485`	`485`	`for (; read_idx < (read_size + match_pos); read_idx++) {`
`486`		`- char c = get_char();`
	`486`	`+ int c = get_char();`
`487`	`487`	`buf_idx = hex ? read_idx/2 : read_idx;`
`488`	`488`	`if (c == -1) {`
`489`	`489`	`pbuf[buf_idx] = '\0';`
`@@ -515,15 +515,15 @@ ssize_t ATHandler::read(char *buf, size_t size, bool read_even_stop_tag, bool he`
`515`	`515`	`pbuf[buf_idx] = c;`
`516`	`516`	`} else {`
`517`	`517`	`if (read_idx % 2 == 0) {`
`518`		`- upper = hex_str_to_int(&c, 1);`
	`518`	`+ upper = hex_str_to_int((const char*)&c, 1);`
`519`	`519`	`} else {`
`520`		`- lower = hex_str_to_int(&c, 1);`
	`520`	`+ lower = hex_str_to_int((const char*)&c, 1);`
`521`	`521`	`pbuf[buf_idx] = ((upper<<4) & 0xF0) \| (lower & 0x0F);`
`522`	`522`	`}`
`523`	`523`	`}`
`524`	`524`	`}`
`525`	`525`
`526`		`- return buf_idx + 1;`
	`526`	`+ return buf_idx;`
`527`	`527`	`}`
`528`	`528`
`529`	`529`	`ssize_t ATHandler::read_string(char *buf, size_t size, bool read_even_stop_tag)`