Skip to content

Commit a682fde

Browse files
committed
Incorporated review comments
1 parent 120ca1b commit a682fde

File tree

65 files changed

+65
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+65
-76
lines changed

TESTS/lorawan/loraradio/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616
#if !defined(MBED_CONF_RTOS_PRESENT)
17-
#error [NOT_SUPPORTED] LORADIO test cases requires RTOS to run.
17+
#error [NOT_SUPPORTED] LORADIO test cases require a RTOS to run.
1818
#else
1919

2020
#include "utest.h"

TESTS/netsocket/dns/asynchronous_dns.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ void ASYNCHRONOUS_DNS()
4242
TEST_ASSERT_EQUAL(0, result_dns_failure);
4343
TEST_ASSERT_EQUAL(0, result_exp_timeout);
4444
}
45-
#endif
45+
#endif // defined(MBED_CONF_RTOS_PRESENT)

TESTS/netsocket/dns/asynchronous_dns_cache.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,4 @@ void ASYNCHRONOUS_DNS_CACHE()
6767
dns_test_hosts[0], data.addr.get_ip_address(), delay_ms);
6868
}
6969
}
70-
#endif
70+
#endif // defined(MBED_CONF_RTOS_PRESENT)

TESTS/netsocket/dns/asynchronous_dns_cancel.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,4 +87,4 @@ void ASYNCHRONOUS_DNS_CANCEL()
8787

8888
ThisThread::sleep_for(5000);
8989
}
90-
#endif // #if defined(MBED_CONF_RTOS_PRESENT)
90+
#endif // defined(MBED_CONF_RTOS_PRESENT)

TESTS/netsocket/dns/asynchronous_dns_simultaneous.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ void ASYNCHRONOUS_DNS_SIMULTANEOUS()
4343
TEST_ASSERT_EQUAL(0, result_dns_failure);
4444
TEST_ASSERT_EQUAL(0, result_exp_timeout);
4545
}
46-
#endif
46+
#endif // defined(MBED_CONF_RTOS_PRESENT)

TESTS/netsocket/dns/asynchronous_dns_simultaneous_cache.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ void ASYNCHRONOUS_DNS_SIMULTANEOUS_CACHE()
4444
TEST_ASSERT_EQUAL(0, result_dns_failure);
4545
TEST_ASSERT_EQUAL(0, result_exp_timeout);
4646
}
47-
#endif
47+
#endif // defined(MBED_CONF_RTOS_PRESENT)

TESTS/netsocket/dns/asynchronous_dns_simultaneous_repeat.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ void ASYNCHRONOUS_DNS_SIMULTANEOUS_REPEAT()
4646
TEST_ASSERT_EQUAL(0, result_exp_timeout);
4747
}
4848
}
49-
#endif
49+
#endif // defined(MBED_CONF_RTOS_PRESENT)

TESTS/netsocket/dns/dns_tests.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
#ifndef DNS_TESTS_H
1919
#define DNS_TESTS_H
20-
#if defined(MBED_CONF_RTOS_PRESENT)
2120

2221
#include "nsapi_dns.h"
2322

@@ -93,5 +92,4 @@ void SYNCHRONOUS_DNS();
9392
void SYNCHRONOUS_DNS_MULTIPLE();
9493
void SYNCHRONOUS_DNS_CACHE();
9594
void SYNCHRONOUS_DNS_INVALID();
96-
#endif /* defined(MBED_CONF_RTOS_PRESENT) */
9795
#endif

TESTS/netsocket/dns/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*/
1717

1818
#if !defined(MBED_CONF_RTOS_PRESENT)
19-
#error [NOT_SUPPORTED] dns test cases requires RTOS to run.
19+
#error [NOT_SUPPORTED] dns test cases require a RTOS to run.
2020
#else
2121

2222
#define WIFI 2

TESTS/netsocket/dns/synchronous_dns.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ void SYNCHRONOUS_DNS()
4141
TEST_ASSERT_EQUAL(0, result_dns_failure);
4242
TEST_ASSERT_EQUAL(0, result_exp_timeout);
4343
}
44-
#endif
44+
#endif // defined(MBED_CONF_RTOS_PRESENT)

0 commit comments

Comments
 (0)