Skip to content

Commit b6df6d5

Browse files
change event names
1 parent 356ec39 commit b6df6d5

File tree

6 files changed

+18
-14
lines changed

6 files changed

+18
-14
lines changed

features/FEATURE_BLE/ble/gap/Gap.h

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ class Gap {
500500
* @param connectionHandle The handle of the connection that changed the size.
501501
* @param attMtuSize
502502
*/
503-
virtual void onAttMtuChanged(
503+
virtual void onAttMtuChange(
504504
connection_handle_t connectionHandle,
505505
uint16_t attMtuSize
506506
)
@@ -509,13 +509,17 @@ class Gap {
509509

510510
/**
511511
* Function invoked when the connections changes the maximum number of octets
512-
* that can be sent or received by the controller in a single packet.
512+
* that can be sent or received by the controller in a single packet. A single
513+
* L2CAP packet can be fragmented across many such packets.
514+
*
515+
* @note This only triggers if controller supports data length extension and
516+
* negotiated data length is longer than the default 23.
513517
*
514518
* @param connectionHandle The handle of the connection that changed the size.
515519
* @param txSize Number of octets we can send on this connection in a single packet.
516520
* @param rxSize Number of octets we can receive on this connection in a single packet.
517521
*/
518-
virtual void onPacketPayloadSizeChanged(
522+
virtual void onDataLengthChange(
519523
connection_handle_t connectionHandle,
520524
uint16_t txSize,
521525
uint16_t rxSize

features/FEATURE_BLE/ble/generic/GenericGap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ class GenericGap :
632632
uint16_t att_mtu_size
633633
);
634634

635-
virtual void on_packet_payload_size_changed(
635+
virtual void on_data_length_change(
636636
connection_handle_t connection_handle,
637637
uint16_t tx_size,
638638
uint16_t rx_size

features/FEATURE_BLE/ble/pal/PalGap.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ struct Gap {
4545
) = 0;
4646

4747
/**
48-
* @copydoc Gap::EventHandler::onAttMtuChanged
48+
* @copydoc Gap::EventHandler::onAttMtuChange
4949
*/
5050
virtual void on_att_mtu_changed(
5151
connection_handle_t connection_handle,
5252
uint16_t att_mtu_size
5353
) = 0;
5454

5555
/**
56-
* @copydoc Gap::EventHandler::onPacketPayloadSizeChanged
56+
* @copydoc Gap::EventHandler::onDataLengthChange
5757
*/
58-
virtual void on_packet_payload_size_changed(
58+
virtual void on_data_length_change(
5959
connection_handle_t connection_handle,
6060
uint16_t tx_size,
6161
uint16_t rx_size

features/FEATURE_BLE/source/generic/GenericGap.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -866,18 +866,18 @@ void GenericGap::on_att_mtu_changed(
866866
)
867867
{
868868
if (_eventHandler) {
869-
_eventHandler->onAttMtuChanged(connection_handle, att_mtu_size);
869+
_eventHandler->onAttMtuChange(connection_handle, att_mtu_size);
870870
}
871871
}
872872

873-
void GenericGap::on_packet_payload_size_changed(
873+
void GenericGap::on_data_length_change(
874874
Handle_t connection_handle,
875875
uint16_t tx_size,
876876
uint16_t rx_size
877877
)
878878
{
879879
if (_eventHandler) {
880-
_eventHandler->onPacketPayloadSizeChanged(connection_handle, tx_size, rx_size);
880+
_eventHandler->onDataLengthChange(connection_handle, tx_size, rx_size);
881881
}
882882
}
883883

features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioBLE.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ void BLE::device_manager_cb(dmEvt_t* dm_event)
291291
ble::pal::Gap::EventHandler *handler;
292292
handler = ble::pal::vendor::cordio::Gap::get_gap().get_event_handler();
293293
if (handler) {
294-
handler->on_packet_payload_size_changed(
294+
handler->on_data_length_change(
295295
dm_event->hdr.param,
296296
dm_event->dataLenChange.maxTxOctets,
297297
dm_event->dataLenChange.maxRxOctets

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_SOFTDEVICE/TARGET_NRF52/source/btle/btle.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ void btle_handler(const ble_evt_t *p_ble_evt)
380380
const ble_gap_evt_data_length_update_t &update =
381381
p_ble_evt->evt.gap_evt.params.data_length_update;
382382

383-
gap._eventHandler->onPacketPayloadSizeChanged(
383+
gap._eventHandler->onDataLengthChange(
384384
connection,
385385
update.effective_params.max_tx_octets,
386386
update.effective_params.max_rx_octets
@@ -400,7 +400,7 @@ void btle_handler(const ble_evt_t *p_ble_evt)
400400
const ble_gatts_evt_exchange_mtu_request_t &update =
401401
p_ble_evt->evt.gatts_evt.params.exchange_mtu_request;
402402

403-
gap._eventHandler->onAttMtuChanged(
403+
gap._eventHandler->onAttMtuChange(
404404
connection,
405405
std::min(NRF_SDH_BLE_GATT_MAX_MTU_SIZE, (int)(update.client_rx_mtu))
406406
);
@@ -415,7 +415,7 @@ void btle_handler(const ble_evt_t *p_ble_evt)
415415
const ble_gattc_evt_exchange_mtu_rsp_t &update =
416416
p_ble_evt->evt.gattc_evt.params.exchange_mtu_rsp;
417417

418-
gap._eventHandler->onAttMtuChanged(
418+
gap._eventHandler->onAttMtuChange(
419419
connection,
420420
std::min(NRF_SDH_BLE_GATT_MAX_MTU_SIZE, (int)(update.server_rx_mtu))
421421
);

0 commit comments

Comments
 (0)