Refactored away onboard_modem_api because it is not needed at all

All targets must implement soft_- and hard_power_on/off() functions which are practically same what onboard_modem_api offered.
These were seen as a duplicate features and therefore we removed this.
All targets involved have been updated to reflect the changes

Author: Antti Kauppila

features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96.cpp

@@ -15,7 +15,6 @@
  * limitations under the License.
  */
 
-#include "onboard_modem_api.h"
 #include "QUECTEL_UG96.h"
 #include "QUECTEL_UG96_CellularContext.h"
 #include "AT_CellularNetwork.h"

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/TARGET_RIOT_MICRO_MODULE/ONBOARD_RM1000_AT.cpp

@@ -17,14 +17,18 @@
 #if MBED_CONF_NSAPI_PRESENT
 
 #include "ONBOARD_RM1000_AT.h"
-#include "cellular/onboard_modem_api.h"
 #include "UARTSerial.h"
 
 #include "mbed-trace/mbed_trace.h"
 #ifndef TRACE_GROUP
 #define TRACE_GROUP  "RIOTMICRO"
 #endif // TRACE_GROUP
 
+#include "gpio_api.h"
+#include "PinNames.h"
+#include "hal/serial_api.h"
+#include "platform/mbed_thread.h"
+
 using namespace mbed;
 
 ONBOARD_RM1000_AT::ONBOARD_RM1000_AT(FileHandle *fh) : RM1000_AT(fh)
@@ -49,18 +53,89 @@ nsapi_error_t ONBOARD_RM1000_AT::soft_power_on()
 {
     tr_debug("Calling ONBOARD_RM1000_AT::soft_power_on");
 
-    ::onboard_modem_init();
+    onboard_modem_init();
     return NSAPI_ERROR_OK;
 }
 
 nsapi_error_t ONBOARD_RM1000_AT::soft_power_off()
 {
     tr_debug("Calling ONBOARD_RM1000_AT::soft_power_off");
 
-    ::onboard_modem_deinit();
+    onboard_modem_deinit();
     return NSAPI_ERROR_OK;
 }
 
+void ONBOARD_RM1000_AT::onboard_modem_init()
+{
+    char promptEnd;
+
+    tr_debug("onboard_modem_init");
+
+    gpio_t gpio;
+
+    gpio_init_out_ex(&gpio, MDMCHEN, 0);
+    gpio_init_out_ex(&gpio, MDMREMAP, 0);
+    // Take us out of reset
+    gpio_init_out_ex(&gpio, MDMRST, 0);
+    thread_sleep_for(100);
+    gpio_write(&gpio, 1);
+
+    /* Initialize UART1 pins to allow collecting logs from a PC */
+    gpio_init_in_ex(&gpio, MDM_UART1_TXD, PullNone);
+    gpio_init_in_ex(&gpio, MDM_UART1_RXD, PullNone);
+
+    serial_t bootrom_uart;
+    serial_init(&bootrom_uart, MDM_UART0_TXD, MDM_UART0_RXD);
+    serial_baud(&bootrom_uart, 115200);
+
+    tr_debug("%s: MODEM RESET", __func__);
+
+    serial_getc(&bootrom_uart);
+    tr_debug("%s: MODEM first activity after reset", __func__);
+    /* Wait for some dots */
+    for (int i = 0; i < 3; i++) {
+        do {
+            promptEnd = serial_getc(&bootrom_uart);
+        } while ('.' != promptEnd);
+    }
+    serial_putc(&bootrom_uart, ' ');
+    /* Wait for bootrom prompt */
+    for (int i = 0; i < 2; i++) {
+        do {
+            promptEnd = serial_getc(&bootrom_uart);
+        } while ('>' != promptEnd);
+    }
+    serial_putc(&bootrom_uart, '6');
+    serial_free(&bootrom_uart);
+
+    /* Wait for stack prompt */
+    tr_debug("%s: Wait for stack prompt", __func__);
+    thread_sleep_for(100);
+    serial_t cli_uart;
+    serial_init(&cli_uart, MDM_UART3_TXD, MDM_UART3_RXD);
+    serial_baud(&cli_uart, 230400); /* TODO make baud rate configurable */
+
+    do {
+        promptEnd = serial_getc(&cli_uart);
+    } while ('>' != promptEnd);
+
+    serial_free(&cli_uart);
+
+    tr_debug("%s: MODEM CLI prompt reached", __func__);
+
+    tr_debug("Reset RM1000 completed");
+}
+
+void ONBOARD_RM1000_AT::onboard_modem_deinit()
+{
+    tr_debug("onboard_modem_deinit");
+
+    gpio_t gpio;
+
+    // Back into reset
+    gpio_init_out_ex(&gpio, MDMRST, 0);
+}
+
 CellularDevice *CellularDevice::get_target_default_instance()
 {
     tr_debug("Calling CellularDevice::get_target_default_instance from ONBOARD_RM1000_AT");

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/TARGET_RIOT_MICRO_MODULE/ONBOARD_RM1000_AT.h

@@ -31,6 +31,11 @@ class ONBOARD_RM1000_AT : public RM1000_AT
     virtual nsapi_error_t hard_power_off();
     virtual nsapi_error_t soft_power_on();
     virtual nsapi_error_t soft_power_off();
+
+private:
+    void onboard_modem_init();
+
+    void onboard_modem_deinit();
 };
 
 } // namespace mbed

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/TARGET_RIOT_MICRO_MODULE/onboard_modem_api.c

@@ -19,12 +19,16 @@
 
 #if EP_AGORA_ENABLE_CELL
 
-#include "cellular/onboard_modem_api.h"
+#include "gpio_api.h"
+#include "platform/mbed_thread.h"
+#include "PinNames.h"
+
 #include "UARTSerial.h"
 #include "ONBOARD_TELIT_ME910.h"
 #include "ThisThread.h"
 #include "CellularLog.h"
 
+
 using namespace mbed;
 
 ONBOARD_TELIT_ME910::ONBOARD_TELIT_ME910(FileHandle *fh) : TELIT_ME910(fh, PIN_NAME_CELL_ON_OFF, true)
@@ -33,27 +37,27 @@ ONBOARD_TELIT_ME910::ONBOARD_TELIT_ME910(FileHandle *fh) : TELIT_ME910(fh, PIN_N
 
 nsapi_error_t ONBOARD_TELIT_ME910::hard_power_on()
 {
-    ::onboard_modem_init();
+    onboard_modem_init();
     return NSAPI_ERROR_OK;
 }
 
 nsapi_error_t ONBOARD_TELIT_ME910::hard_power_off()
 {
-    ::onboard_modem_deinit();
+    onboard_modem_deinit();
     return NSAPI_ERROR_OK;
 }
 
 nsapi_error_t ONBOARD_TELIT_ME910::soft_power_on()
 {
-    ::onboard_modem_power_up();
+    onboard_modem_power_up();
     // From Telit_xE910 Global form factor App note: It is mandatory to avoid sending data to the serial ports during the first 200ms of the module start-up.
     rtos::ThisThread::sleep_for(200);
     return NSAPI_ERROR_OK;
 }
 
 nsapi_error_t ONBOARD_TELIT_ME910::soft_power_off()
 {
-    ::onboard_modem_power_down();
+    onboard_modem_power_down();
     return NSAPI_ERROR_OK;
 }
 
@@ -122,6 +126,52 @@ nsapi_error_t ONBOARD_TELIT_ME910::init()
     return _at->unlock_return_error();
 }
 
+void ONBOARD_TELIT_ME910::press_power_button(int time_ms)
+{
+    gpio_t gpio;
+
+    gpio_init_out_ex(&gpio, PIN_NAME_CELL_ON_OFF, 1);
+    gpio_write(&gpio, 0);
+    thread_sleep_for(time_ms);
+    gpio_write(&gpio, 1);
+}
+
+void ONBOARD_TELIT_ME910::onboard_modem_init()
+{
+    gpio_t gpio;
+
+    gpio_init_out_ex(&gpio, PIN_NAME_CELL_POWER_ENABLE, 0);
+    gpio_write(&gpio, 1);
+}
+
+void ONBOARD_TELIT_ME910::onboard_modem_deinit()
+{
+    gpio_t gpio;
+
+    gpio_init_out_ex(&gpio, PIN_NAME_CELL_POWER_ENABLE, 1);
+    gpio_write(&gpio, 0);
+}
+
+void ONBOARD_TELIT_ME910::onboard_modem_power_up()
+{
+    /* keep the power line low for 5 seconds */
+    press_power_button(5000);
+    /* give modem a little time to respond */
+    thread_sleep_for(20 * 1000);
+}
+
+void ONBOARD_TELIT_ME910::onboard_modem_power_down()
+{
+    gpio_t gpio;
+
+    gpio_init_out_ex(&gpio, PIN_NAME_CELL_ON_OFF, 0);
+    /* keep the power line low for more than 3 seconds.
+     * If 3G_ON_OFF pin is kept low for more than a second, a controlled disconnect and shutdown takes
+     * place, Due to the network disconnect, shut-off can take up to 30 seconds. However, we wait for 10
+     * seconds only   */
+    thread_sleep_for(10 * 1000);
+}
+
 CellularDevice *CellularDevice::get_target_default_instance()
 {
     static UARTSerial serial(MDMTXD, MDMRXD, 115200);

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_AGORA/ONBOARD_TELIT_ME910.cpp

@@ -31,6 +31,17 @@ class ONBOARD_TELIT_ME910 : public TELIT_ME910 {
     virtual nsapi_error_t hard_power_off();
     virtual nsapi_error_t soft_power_on();
     virtual nsapi_error_t soft_power_off();
+
+private:
+    void press_power_button(int time_ms);
+
+    void onboard_modem_init();
+
+    void onboard_modem_deinit();
+
+    void onboard_modem_power_up();
+
+    void onboard_modem_power_down();
 };
 
 } // namespace mbed